[
https://issues.apache.org/jira/browse/TAMAYA-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15686398#comment-15686398
]
Thomas Liebetraut commented on TAMAYA-198:
------------------------------------------
Sorry for the late reply, I had a really bad cold over the weekend and did not
feel up to doing intellectual work.
I was also under the impression that I don't need an ICLA for submitted patches
but only for becomming a committer myself. But I can still sign the CLA if you
want me to.
[~johndament] The patch was created with {{git format-patch}} according to the
Developer Guide so I don't know what went wrong. By pull request, do you mean
at github against the mirror, or is there a apache-internal way to create PRs?
> tamaya-formats blindly tries (and failes) to parse a config file with
> multiple formats
> --------------------------------------------------------------------------------------
>
> Key: TAMAYA-198
> URL: https://issues.apache.org/jira/browse/TAMAYA-198
> Project: Tamaya
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 0.3-incubating
> Reporter: Thomas Liebetraut
> Assignee: Oliver B. Fischer
> Attachments: TAMAYA-198.patch
>
>
> BaseFormatPropertySourceProvider can handle multiple formats registered. This
> is useful in my project because we actually support multiple formats for a
> certain type of config file and this way we can implement one Provider which
> can provide PropertySources for all of them.
> But {{getPropertySources()}} will
> # blindly try all files with all formats. E.g. if both, "properties" and
> "ini" formats are registered, it will try all files with both formats without
> checking {{format.accepts()}} first.
> # try all the formats with the same {{InputStream}}. If the previous format
> does not reset the input stream, it is already at the end of the file and the
> following formats don't have anything left to read, returning {{null}}. This
> leads to some {{NullPointerException}}s being logged.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
