Re: using assertj for better test matchers - objections?

[P. Ottlinger]

Hi again,

Am 06.01.2017 um 23:03 schrieb P. Ottlinger:
> I'm beginning to understand those random build failures .... our
> structure is very complex ...

in case someone can point me to my mistake .... attached you can find my
changes to the current incubator-tamaya-extensions.

Unfortunately I'm unable to import assertJ -
can someone help me, please?

Cheers,
Phil

diff --git a/modules/events/pom.xml b/modules/events/pom.xml
index 1e80133..584a762 100644
--- a/modules/events/pom.xml
+++ b/modules/events/pom.xml
@@ -64,6 +64,12 @@ under the License.
         </dependency>
 
         <dependency>
+            <groupId>org.assertj</groupId>
+            <artifactId>assertj.core</artifactId>
+            <version>${assertj.version}</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
             <groupId>junit</groupId>
             <artifactId>junit</artifactId>
         </dependency>
diff --git a/modules/events/src/test/java/org/apache/tamaya/events/ConfigurationChangeTest.java b/modules/events/src/test/java/org/apache/tamaya/events/ConfigurationChangeTest.java
index 904f3db..93530c4 100644
--- a/modules/events/src/test/java/org/apache/tamaya/events/ConfigurationChangeTest.java
+++ b/modules/events/src/test/java/org/apache/tamaya/events/ConfigurationChangeTest.java
@@ -25,7 +25,7 @@ import org.junit.Test;
 import java.util.Map;
 
 import static org.junit.Assert.*;
-
+import static org.assertj.core.api.Assertions.*;
 /**
  * Test class for {@link ConfigurationChange}.
  */
@@ -34,8 +34,7 @@ public class ConfigurationChangeTest {
     @Test
     public void testEmptyChangeSet() throws Exception {
         ConfigurationChange change = ConfigurationChange.emptyChangeSet(ConfigurationProvider.getConfiguration());
-        assertNotNull(change);
-        assertTrue(change.isEmpty());
+        assertThat(change).isNotNull().isEmpty();
     }
 
     @Test
diff --git a/pom.xml b/pom.xml
index ab5c988..20b2d74 100644
--- a/pom.xml
+++ b/pom.xml
@@ -61,6 +61,7 @@ under the License.
         <json.spec.version>1.0-alpha-1</json.spec.version>
         <johnzon.version>0.9-incubating</johnzon.version>
         <junit.version>4.12</junit.version>
+        <assertj.version>3.6.1</assertj.version>
 
         <!-- Dependency and plugin relate version properties go here -->
         <arquillian.version>1.1.7.Final</arquillian.version>
@@ -230,6 +231,13 @@ under the License.
                 <scope>test</scope>
             </dependency>
 
+            <!-- with mvn 3.3.9 this definition is not inherited among multiple parent-pom relationships -->
+            <dependency>
+                <groupId>org.assertj</groupId>
+                <artifactId>assertj-core</artifactId>
+                <version>${assertj.version}</version>
+                <scope>test</scope>
+            </dependency>
             <dependency>
                 <groupId>junit</groupId>
                 <artifactId>junit</artifactId>
@@ -967,4 +975,15 @@ under the License.
             </plugin>
         </plugins>
     </reporting>
+    <repositories>
+     <repository>
+        <snapshots>
+          <enabled>false</enabled>
+        </snapshots>
+        <id>maven-central</id>
+        <name>Maven Central Repository</name>
+        <url>https://repo1.maven.org/maven2</url>
+      </repository>
+    </repositories>
+
 </project>

signature.asc
Description: OpenPGP digital signature