Ok, cool. I'm probably going to try to expand some test coverage of tamaya-extensions next (TAMAYA-291); I'll be sure to use AssertJ for that.
Thanks! ________________________________________ From: P. Ottlinger <pottlin...@apache.org> Sent: Sunday, February 25, 2018 2:05 PM To: dev@tamaya.incubator.apache.org Subject: Re: [jira] [Commented] (TAMAYA-288) Ensure that a successful build of Tamaya API&Core requires a unit test coverage of at least 50% Thanks for your contribution :-) We try to migrate to AssertJ instead of plain JUnit assertions, but I nevertheless accepted the PR and commited it to master. Thanks Phil Am 25.02.2018 um 06:34 schrieb ASF GitHub Bot (JIRA): > > [ > https://issues.apache.org/jira/browse/TAMAYA-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375947#comment-16375947 > ] > > ASF GitHub Bot commented on TAMAYA-288: > --------------------------------------- > > GitHub user peculater opened a pull request: > > https://github.com/apache/incubator-tamaya/pull/14 > > TAMAYA-288: Additional test coverage > > Looks huge and scary, but it's honestly just adding tests. > > Things that this PR does: > * Significant increase in test coverage, especially mutation coverage > ** API from 57% to 92% > ** Core from 38% to 82% > ** SPI-Support from ??% (mutation coverage disabled) to 86% > * Tests now succeed with OpenJDK, Hotspot, and OpenJ9. > * Generated a series of additional bug tickets. :-) > > What this does not do: > * Touch any implementation code. This is only tests. > * Reduce code duplication, especially between API/Core and SPI-Support. > * Have a great answer for OSGI testing. It ends up being a pile of mocks. > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/peculater/incubator-tamaya TAMAYA-288 > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/incubator-tamaya/pull/14.patch > > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > > This closes #14
