[
https://issues.apache.org/jira/browse/TAMAYA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386434#comment-16386434
]
ASF GitHub Bot commented on TAMAYA-331:
---------------------------------------
GitHub user acoburn opened a pull request:
https://github.com/apache/incubator-tamaya/pull/18
Add Automatic-Module-Name metadata
Addresses TAMAYA-331
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/acoburn/incubator-tamaya TAMAYA-331
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tamaya/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit 8fb00475f88ce8a337b02c794a2e489501687520
Author: Aaron Coburn <acoburn@...>
Date: 2018-03-05T17:55:15Z
Add Automatic-Module-Name metadata
----
> Add Automatic-Module-Name metadata for use with JDK 9+ module system
> --------------------------------------------------------------------
>
> Key: TAMAYA-331
> URL: https://issues.apache.org/jira/browse/TAMAYA-331
> Project: Tamaya
> Issue Type: Improvement
> Components: API, Core, Extensions
> Reporter: Aaron Coburn
> Priority: Major
> Fix For: 0.4-incubating
>
>
> The Java 9 module system (JSR-376) expects each JAR file to declare a module
> name. When building explicitly for Java 9+, the module.info file is used to
> define the imported and exported modules for a given JAR, but given that
> Tamaya targets JDK 1.8, the simplest way to define a module name for the
> released artifacts is to define an Automatic-Module-Name entry in each JAR's
> MANIFEST.MF file. Specifically, this would involve adding an appropriate line
> to the various bnd.bnd files in the code base.
> In general, it seems that the defined module name would be the same as the
> OSGi exported module name: tamaya-core exports org.apache.tamaya.core via
> OSGi, so using the same (o.a.t.core) name would make the most sense.
> The tamaya-api module, however, exports two modules: o.a.t and o.a.t.spi. I
> would suggest that tamaya-api's module name be: org.apache.tamaya.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
