[ 
https://issues.apache.org/jira/browse/TAMAYA-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387901#comment-16387901
 ] 

ASF GitHub Bot commented on TAMAYA-333:
---------------------------------------

GitHub user acoburn opened a pull request:

    https://github.com/apache/incubator-tamaya/pull/19

    TAMAYA-333: null checks for ::equals(Object) methods

    This adds a null check for arguments passed to ::equals methods in the
    various converter classes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/acoburn/incubator-tamaya TAMAYA-333

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tamaya/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19
    
----
commit 6119affa7b0c9e7841c21a9af23e07a4f6c1ca2d
Author: Aaron Coburn <acoburn@...>
Date:   2018-03-06T14:56:11Z

    TAMAYA-333: null checks for ::equals(Object) methods
    
    This adds a null check for arguments passed to ::equals methods in the
    various converter classes.

----


> ::equals(Object) implementation should correctly handle null arguments
> ----------------------------------------------------------------------
>
>                 Key: TAMAYA-333
>                 URL: https://issues.apache.org/jira/browse/TAMAYA-333
>             Project: Tamaya
>          Issue Type: Bug
>          Components: Core
>            Reporter: Aaron Coburn
>            Priority: Minor
>             Fix For: 0.4-incubating
>
>
> As described by the findbugs report:
> {quote}This implementation of equals(Object) violates the contract defined by 
> java.lang.Object.equals() because it does not check for null being passed as 
> the argument. All equals() methods should return false if passed a null value.
> {quote}
> The various converter implementations are affected by this. Adding a null 
> check would be very easy to include.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to