[
https://issues.apache.org/jira/browse/TAMAYA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406911#comment-16406911
]
ASF GitHub Bot commented on TAMAYA-330:
---------------------------------------
GitHub user acoburn opened a pull request:
https://github.com/apache/incubator-tamaya-extensions/pull/3
TAMAYA-330: Add jdk9+ build support
This change makes it possible to build Tamaya extensions on JDK 9 and 10.
Most of the changes here related to Maven plugin updates or updates to the
dependencies of the Maven plugins. The only code-level change of any
consequence is that the OSGi bnd packaging now imports the `javax.annotation`
package. In JDK 9+, the Java EE packages are no longer available by default,
and so `javax.annotation` must be explicitly imported.
Also, one of the microprofile tests had to be changed -- the test was
expecting that converting the Java version into an `Integer` would throw an
`IllegalArgumentException`. However, with JDK 10, the Java version _is_ an
`Integer`. I changed the type to `java.time.Instant`, which throws the expected
exception in Java 8, 9 and 10.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/acoburn/incubator-tamaya-extensions TAMAYA-330
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tamaya-extensions/pull/3.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3
----
commit 54b190666c28df138595cc0fdc39a632e5842a7b
Author: Aaron Coburn <acoburn@...>
Date: 2018-03-20T19:33:11Z
TAMAYA-330: Add jdk9+ build support
This change makes it possible to build Tamaya extensions on JDK 9 and 10.
----
> Make it possible to build Tamaya on JDK 9+
> ------------------------------------------
>
> Key: TAMAYA-330
> URL: https://issues.apache.org/jira/browse/TAMAYA-330
> Project: Tamaya
> Issue Type: Improvement
> Components: API, Core, Extensions
> Environment: jdk9 and jdk10 build environments.
> Reporter: Aaron Coburn
> Priority: Minor
> Fix For: 0.4-incubating
>
>
> While the current codebase is _usable_ in JDK 9+ environments, it is not
> possible to _build_ the source code with JDK 9 or later.
> The limiting factor is the karaf plugin requiring some Java EE libraries that
> are no longer available by default (javax.xml.bind and javax.activation).
> Adding an explicit dependency within the plugin configuration resolves this.
> Also, for JDK 10, the javadoc plugin is unable to parse the JVM version
> string. This is due to the fact that the javadoc plugin uses commons-lang3
> version 3.5; upgrading that plugin's dependency to commons-lang3 3.7 fixes
> this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
