GitHub user acoburn opened a pull request:
https://github.com/apache/incubator-tamaya-sandbox/pull/2
Get code to build and test successfully on JDK9+
This change updates the Tamaya sandbox code to make it build properly on
JDK9+.
One issue I encountered was that, at present (under JDK 1.8), the test
suite does not run, and there were two problems in the `collections` extension.
The first issue related to a missing `.` character in the construction of the
item separator value from the configuration. The second was, for a custom item
converter, the code is expecting the value `.item-converters` but the test
fixture was using `.item-converter`. There is no existing documentation that I
saw indicating that it should be one way instead of the other, so I am assuming
that it is correct in the code and incorrect in the test.
Another issue I encountered -- and this only happens under JDK10 -- is that
in the `vertx` extension test, the filtered response from the JAVA environment
entries varies. Under jdk8 and jdk9 this list includes `user.home`, `user.name`
and `java.version`, but under jdk10, the response also includes
`java.version.date`. And so the test that checks for three entries in the `Map`
will fail. I simply removed that check.
And other than a simple javadoc fix (jdk10 is more strict about javadocs),
this change is primarily about adding JavaEE modules as runtime dependencies.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/acoburn/incubator-tamaya-sandbox TAMAYA-330
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tamaya-sandbox/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
----
commit 0f32957040687f9a16278a5481657244539ec09b
Author: Aaron Coburn <acoburn@...>
Date: 2018-04-05T19:16:22Z
Get code to build and test successfully on JDK9+
----
---
