[
https://issues.apache.org/jira/browse/TAMAYA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539690#comment-16539690
]
ASF GitHub Bot commented on TAMAYA-273:
---------------------------------------
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya-sandbox/pull/7
TAMAYA-273 Fix infinite recursion in metamodel
With the lazily loaded configuration in metamodel, the logic is
susceptible to an infinite recursion if any part of the configuration
setting does a getConfiguration in the middle. The spi delegation logic
added getConfiguration logging to all static calls as part of
https://github.com/apache/incubator-tamaya/commit/5a130523ab7d3a9d33091b13f62db90ddb8fba5c
which caused this module to infinitely recurse and fail.
This commit breaks the recursion cycle and extends the tests to be more
precise.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peculater/incubator-tamaya-sandbox
TAMAYA-273-recursion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tamaya-sandbox/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
----
commit a99008aecb47bbb09df2c5608e91ed540bc6a2d3
Author: William Lieurance <william.lieurance@...>
Date: 2018-07-11T07:37:21Z
TAMAYA-273 Fix infinite recursion in metamodel
With the lazily loaded configuration in metamodel, the logic is
susceptible to an infinite recursion if any part of the configuration
setting does a getConfiguration in the middle. The spi delegation logic
added getConfiguration logging to all static calls as part of
5a130523ab7d3a9d33091b13f62db90ddb8fba5c in incubator-tamaya, which
caused this module to infinitely recurse and fail. This commit breaks
the chain of possible recursion.
----
> Describe current configuration provider configuration upon Tamaya launch
> ------------------------------------------------------------------------
>
> Key: TAMAYA-273
> URL: https://issues.apache.org/jira/browse/TAMAYA-273
> Project: Tamaya
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.3-incubating
> Reporter: Philipp Ottlinger
> Assignee: Anatole Tresch
> Priority: Major
>
> After starting an application that makes use of Tamaya I want to see which
> configuration providers are activated and in which order they appear. At the
> moment the output is:
> {code}
> Jun 12, 2017 8:24:05 PM org.apache.tamaya.spi.ServiceContextManager
> loadDefaultServiceProvider
> INFORMATION: Using Service Context of type:
> org.apache.tamaya.core.internal.DefaultServiceContext
> Jun 12, 2017 8:24:05 PM org.apache.tamaya.ConfigurationProvider spi
> {code}
> A possible output (toString() of providers?) could be the ordinal and a short
> hint how the provider works or what services it offers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
