atsticks commented on a change in pull request #25: TAMAYA-216: Migrate test
assertions to assertj
URL:
https://github.com/apache/incubator-tamaya-extensions/pull/25#discussion_r248442001
##########
File path:
modules/collections/src/test/java/org/apache/tamaya/collections/CollectionAdvancedTests.java
##########
@@ -47,12 +45,12 @@
public void testCustomSeparator(){
Configuration config = Configuration.current();
List<String> items = config.get("sep-list", new
TypeLiteral<List<String>>(){});
- assertNotNull(items);
- assertFalse(items.isEmpty());
- assertEquals(3, items.size());
- assertEquals("a,b,c", items.get(0));
- assertEquals("d,e,f", items.get(1));
- assertEquals("g,h,i", items.get(2));
+ assertThat(items).isNotNull();
+ assertThat(items.isEmpty()).isFalse();
Review comment:
I agree, I would never the less merge the change. We can still improve it
later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
