Hmm....I probably should have done more reading before implementing. Will revert the changes either tomorrow or definitely the day after.
On 7/24/06, Nick Westgate <[EMAIL PROTECTED]> wrote:
Hi Henri. Although what you say makes sense in your case, validate/pageValidate/PageValidateListener were originally intended to validate that "the user is allowed to visit the page". http://tapestry.apache.org/tapestry4/tapestry/apidocs/org/apache/tapestry/IPage.html#validate(org.apache.tapestry.IRequestCycle) Traditionally confusing Tapestry naming, I know ;-) but I use it in this way, and also to throw redirects to https etc. If the order is changed then it will be a breaking change for me, and I suspect for others too, but more importantly we would need to keep in mind that activity in activateExternalPage would not be safe-guarded by pageValidate from malicious use. Security code intended for all pages should be executed before activateExternalPage. It could be placed in pageAttached, but initialization code you are putting in pageValidate has traditionally been put in pageBeginRender as suggested here: http://tapestry.apache.org/tapestry4/tapestry/apidocs/org/apache/tapestry/IPage.html#attach(org.apache.tapestry.IEngine,%20org.apache.tapestry.IRequestCycle) Is the stuff you put in pageValidate per-page? Why not pageBeginRender? A bit of discussion might be nice before shuffling page events around. ;-) Cheers, Nick. Henri Dupre wrote: > On 7/24/06, Jesse Kuhnert <[EMAIL PROTECTED]> wrote: > >> >> Sure, I can do that. >> >> 4.1 is still "unstable", so I guess if this breaks someone I can always >> revert pretty easily. I'll do it later today and reply back when it's >> deployed. > > > > Fantastic. I'm starting to really like the frequent releases. > > Thanks, > > Henri. > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- Jesse Kuhnert Tacos/Tapestry, team member/developer Open source based consulting work centered around dojo/tapestry/tacos/hivemind.
