[ http://issues.apache.org/jira/browse/TAPESTRY-773?page=all ]

Andreas Andreou updated TAPESTRY-773:
-------------------------------------

    Issue Type: Improvement  (was: Bug)

> Excess code generate for required parameters
> --------------------------------------------
>
>                 Key: TAPESTRY-773
>                 URL: http://issues.apache.org/jira/browse/TAPESTRY-773
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 4.0
>            Reporter: Howard M. Lewis Ship
>            Priority: Minor
>
> When Tapestry is generating code to support component parameters, it 
> generates code such as the following for the setter method:
> public void setRefresh(org.apache.tapestry.IActionListener $1)
> {
>   if (! isInActiveState())
>   {
>     _$refresh$Default = $1;
>     return;
>   }
>   org.apache.tapestry.IBinding binding = getBinding("refresh");
>   if (binding == null)
>     throw new org.apache.hivemind.ApplicationRuntimeException("Parameter 
> 'refresh' is not bound and can not be updated.");
>   binding.setObject(($w) $1);
>   if (isRendering())
>   {
>     _$refresh = $1;
>     _$refresh$Cached = true;
>   }
> }
> The binding == null check in the middle should be omitted for required 
> parameters, which will always be bound. This will save (a tiny amount of) 
> processing time when generating this code.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to