[ http://issues.apache.org/jira/browse/TAPESTRY-1102?page=comments#action_12438638 ] Jesse Kuhnert commented on TAPESTRY-1102: -----------------------------------------
Thanks for the input, never had any one care as much about these things. Sounds reasonable to me.. I've done the first one already (tabStart). The escape key handling I'd love to see implemented as well. I know the editor widget in dojo handles some of these common keys, so perhaps looking at (don't think it's going to be fun exactly ....Some of the keywords to look for are execCommand ...stuff like that): http://trac.dojotoolkit.org/browser/trunk/src/widget/RichText.js If it doesn't become immediately obvious for you let me know and I'll peg the dojo guy who wrote their event system for some help. The biggest hint will be that RichText (maybe Editor2 instead? ) widget...I know how to do it easily enough on "existing" events - but your uses are more advanced. We'd probably love to see more of this type of key handling generalized in dojo as well if it's not already, so feel free to ping me jkuhnert @ gmail. com if you feel like you've found something dojo isn't handling.. To answer your original question about styling though, just take a look at the current definition for "summarizeErrors" in the tapestry javascript package...You can override that function , or you can override the "AlertDialog" in the tapestry javascript namespace..(or extend and override ) ...I know I know...dojo has namespace concepts as well - and not the javascript kind strictly - they are more like tapestry namespaces...how funny is that? ;) http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form/validation.js?view=markup I'll deploy the changes I just made in a few more minutes if all goes well.. (This will be the latest pre 0.4 code available from dojo as of an hour or so ago.....It will probably continue to get updated fairly frequently as long as major bug fixing keeps happening - and especially when something in particular gets dropped in that my friend is working on..) > AlertDialog doesn't trap tabs or set focus to the button > -------------------------------------------------------- > > Key: TAPESTRY-1102 > URL: http://issues.apache.org/jira/browse/TAPESTRY-1102 > Project: Tapestry > Issue Type: Bug > Components: JavaScript > Affects Versions: 4.1.1 > Reporter: Greg Woolsey > > The AlertDialog widget used by the validation framework has a couple of > navigation issues: > 1) When it comes up, the "OK" button doesn't have the focus, but it appears > to the user to be the only active page element. > 2) Users can tab and shift-tab away from the dialog and enter data in form > fields behind the bakground iframe. This is non-intuitive, and almost always > undesired behavior. > It appears from the parent class, DoJo's Dialog.js that giving the button a > tabIndex, setting it as this.tabStart, and setting initial focus to it should > fix these. > Hard-core would be to trap all keystrokes and stop any key event that wasn't > space or enter, but that's probably more of a hammer than is needed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
