[ 
https://issues.apache.org/jira/browse/TAPESTRY-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494346
 ] 

Richard Pitt commented on TAPESTRY-1218:
----------------------------------------

EngineServiceLink line 226 defines the separator: sep = "&";

I don't know if this code needs to sometimes escape the character and sometimes 
not.
If not then this should fix it: sep = "&";

Here is the stack trace:
EngineServiceLink.addParameters(StringBuffer) line: 226 
EngineServiceLink.constructURL(StringBuffer, String, boolean) line: 187 
EngineServiceLink.getURL(String, boolean) line: 140     
EngineServiceLink.getURL() line: 135    
PrivateAsset.buildURL() line: 72        
AjaxShellDelegate.render(IMarkupWriter, IRequestCycle) line: 91 
$Shell_136(Shell).renderComponent(IMarkupWriter, IRequestCycle) line: 109       
$Shell_136(AbstractComponent).render(IMarkupWriter, IRequestCycle) line: 710    
DefaultResponseBuilder.render(IMarkupWriter, IRender, IRequestCycle) line: 174  
$Home_106(BaseComponent).renderComponent(IMarkupWriter, IRequestCycle) line: 92 

> URL to dojo.js is not escaped
> -----------------------------
>
>                 Key: TAPESTRY-1218
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1218
>             Project: Tapestry
>          Issue Type: Bug
>          Components: XHR/dhtml/Ajax
>    Affects Versions: 4.1.1
>         Environment: WinXP. FireFox 2.0.
>            Reporter: Kent Tong
>             Fix For: 4.1.2
>
>
> The AjaxShellDelegate generates code like:
>     <script type="text/javascript" 
> src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> but the & is not escaped. It should be:
>     <script type="text/javascript" 
> src="/AJAXApp/app?service=asset&amp;path=%2Fdojo%2Fdojo.js"></script>
> I think 
> http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html
>  should be used in the render() method in AjaxShellDelegate.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to