Yes to both. (I think? ) I haven't touched eclipse in a few weeks now and don't anticipate doing it again anytime soon so I guess it'll be a free for all between you and whoever else uses it. (I think Marcus does as well)
As for general code cleanup yes definitely, just so long as everything still passed unit tests and such I think it sounds ok. No better way to get comfortable with making changes than starting with the small stuff and working outwards. The only thing I ask is that people examine portions of the source code that is obviously Howard's and try to emulate the same style as much as possible in everything else. I try but am not always successful in making things as easy to read as he is (yet) . On 6/6/07, Ben Dotte <[EMAIL PROTECTED]> wrote:
I'm viewing the Tapestry 4.1.2 source in Eclipse and I notice there is an Eclipse setting committed to the repository to set the compiler to error on unused local variables (tapestry/.settings/org.eclipse.jdt.core.prefs org.eclipse.jdt.core.compiler.problem.unusedLocal=error). This results in 14 errors showing up on the Problems tab due to unused local variables. My access to SVN isn't setup yet but once it is would anyone have a problem if I changed this to a warning instead of an error? Or perhaps the unused local variables shouldn't be there in the first place? --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- Jesse Kuhnert Tapestry/Dojo team member/developer Open source based consulting work centered around dojo/tapestry/tacos/hivemind. http://blog.opencomponentry.com
