Yeah, making all of those use the System property of line.separator sounds
good to me.
On 7/25/07, Ben Dotte <[EMAIL PROTECTED]> wrote:
I'm finding the inconsistent use of
System.getProperty("line.separator") vs. just "\n" is causing a bunch
of unit tests in tapestry-framework to fail on my windows machine (the
system property resolves to \r\n). I'm thinking about switching all of
the instances of \n that cause a test failure to the system property
instead so the project builds correctly for me, unless anyone can
think of a reason this would cause problems?
An example is the assertBuffer() call at the end of
DojoAjaxResponseBuilderTest.test_Render_Response_Already_Started():
expected: java.lang.String = [EMAIL PROTECTED]"<?xml
version=\"1.0\" encoding=\"UTF-8\"?><!DOCTYPE html PUBLIC
\"-//W3C//DTD XHTML 1.0 Transitional//EN\"
\"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\";
[\r\n<!ENTITY nbsp ' '>\r\n]>\r\n<ajax-response></ajax-response>"
actual: java.lang.String = [EMAIL PROTECTED]"<?xml
version=\"1.0\" encoding=\"UTF-8\"?><!DOCTYPE html PUBLIC
\"-//W3C//DTD XHTML 1.0 Transitional//EN\"
\"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\";
[\n<!ENTITY nbsp ' '>\n]>\n<ajax-response></ajax-response>"
(Note the \r\n in expected, vs. \n in actual).
Perhaps after I can get the project to build and unit test suite to
run I can make my first (real) commit!
Thanks,
Ben
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Jesse Kuhnert
Tapestry/Dojo team member/developer
Open source based consulting work centered around
dojo/tapestry/tacos/hivemind. http://blog.opencomponentry.com
