Yep, everything besides the rendering model has mostly been small enhancements so this part hasn't really changed.
The IPropertySource service could definitely be injected instead of adding it to the interface. If the annotation worker you use is currently being created via "instance" just change it to be a real service like one of the other workers and you'll be able to inject that IPropertySource in to that service instance only. Unless IPropertySource is really necessary for the majority of annotation workers it probably doesn't belong in the interface. (not to mention that it may break any custom enhancement stuff people are doing outside of Tapestry - which happens more often than you'd think) On 7/25/07, Howard Lewis Ship <[EMAIL PROTECTED]> wrote:
There's now way that the IPropertySource could be injected? I'm a little foggy on the T4 code base now, but it seems to me that either the IPropertySource could be injected, or the factory for the IPS could be injected. On 7/25/07, Ben Dotte <[EMAIL PROTECTED]> wrote: > > This is my first real commit.. anyone care to comment about anything > they don't like? I wasn't especially happy about changing the > MethodAnnotationEnhancementWorker interface to take in an > IPropertySource but I couldn't think of any other way to get at the new > org.apache.tapestry.default-property-persistence-strategy application > property inside of PersistAnnotationWorker. > > I welcome any comments, I won't take it personally even if it means > reverting the change.. I'm doing my best to remain consistent with the > quality of this codebase, which is quite impressive I think :) > > Thanks, > Ben > > ---------- Forwarded message ---------- > From: [EMAIL PROTECTED] <[EMAIL PROTECTED]> > Date: Jul 25, 2007 4:40 PM > Subject: svn commit: r559620 - in /tapestry/tapestry4/trunk: > tapestry-annotations/src/descriptor/META-INF/ > tapestry-annotations/src/java/org/apache/tapestry/annotations/ > tapestry-annotations/src/test/org/apache/tapestry/annotations/ > tapestry-framework/src/descr... > To: [EMAIL PROTECTED] > > > Author: bdotte > Date: Wed Jul 25 14:40:07 2007 > New Revision: 559620 > > URL: http://svn.apache.org/viewvc?view=rev&rev=559620 > Log: > Resolves TAPESTRY-1448. Add the ability to specify a default @Persist > property persistence strategy in the .application file using the new > org.apache.tapestry.default-property-persistence-strategy property > rather than hardcoding the default on the annotation. > > <<snipped>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- Howard M. Lewis Ship TWD Consulting, Inc. Independent J2EE / Open-Source Java Consultant Creator and PMC Chair, Apache Tapestry Creator, Apache HiveMind Professional Tapestry training, mentoring, support and project work. http://howardlewisship.com
-- Jesse Kuhnert Tapestry/Dojo team member/developer Open source based consulting work centered around dojo/tapestry/tacos/hivemind. http://blog.opencomponentry.com
