Exception page includes partial render of original page
-------------------------------------------------------

                 Key: TAPESTRY-1690
                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1690
             Project: Tapestry
          Issue Type: Bug
          Components: Framework
    Affects Versions: 4.1.3
         Environment: Tapestry 4.1.3 snapshot from 7-27 and Tapestry 4.1.2 
final release, WinXP, Firefox 2
            Reporter: Ben Dotte


Right now the exception page seems to include a partial rendering of the 
original page, followed by the full exception page. An example is posted below. 
This appears to be caused by a change to Shell.java from 5-14-07 where the body 
of the response went from being rendered before the head section to after, as a 
performance enhancement to allow browsers to aggressively download js/css 
includes as they get them before the body is rendered. When the body used to 
get rendered first, the active page after that point was the Exception page, 
making all the head stuff render properly with information about the Exception 
page. Now the head for the active page gets rendered and sent first, after 
which the Exception page is made the active page and rendered after the 
original page's head section.

One possible fix includes moving rendering of the body back to the top (we 
verified this does fix it), but that would kill the performance fix. A better 
option might be to take the approach of DojoAjaxResponseBuilder, and throw away 
the partial response if it is detected that the Exception page has been 
activated.



<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" 
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>
<!-- Application: Widen Media Collective -->
<!-- Page: DirectorAccount -->
<!-- Generated: Thu Aug 02 14:56:43 CDT 2007 -->
<html>
<head>
<meta name="generator" content="Tapestry Application Framework, version 4.1.2" 
/>
<meta http-equiv="Content-Type" content="text/html;charset=UTF-8" />
<title>Trek Media Collective: Digital Asset Management</title>
<meta name="widen-build" content="4.3.0B from Thursday, August 02, 2007; 
02:54:27 PM" />
<meta name="robots" content="noindex,nofollow,noarchive" />
<meta http-equiv="expires" content="Tue, 20 Aug 1996 14:25:27 GMT" />
<link rel="shortcut icon" href="resources/skins/trek/icons/favicon.ico" 
type="image/x-icon" />

<link rel="stylesheet" type="text/css" 
href="resources/skins/trek/css/collective.css" media="screen" />
<link rel="stylesheet" type="text/css" 
href="resources/skins/trek/css/printstyles.css" media="print" />
<script type="text/javascript" src="/scripts/jquery-1.1.2.pack.js"></script>
<script type="text/javascript">jQuery.noConflict();</script>
<script type="text/javascript">djConfig = 
{"isDebug":false,"baseRelativePath":"/dojo-0.4.3/","preventBackButtonFix":true,"parseWidgets":false,"locale":"us"}
 </script>

 <script type="text/javascript" src="/dojo-0.4.3/dojo.js"></script><script 
type="text/javascript" src="/dojo-0.4.3/dojo2.js"></script>
<script type="text/javascript">
dojo.registerModulePath("tapestry", "/tapestry");
</script>
<script type="text/javascript" src="/tapestry/core.js"></script>

<script type="text/javascript">
dojo.require("tapestry.namespace");
tapestry.requestEncoding='UTF-8';
</script>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" 
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>
<!-- Application: Widen Media Collective -->
<!-- Page: ErrorPage -->
<!-- Generated: Thu Aug 02 14:56:45 CDT 2007 -->
<html>
<head>
...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to