[ 
https://issues.apache.org/jira/browse/TAPESTRY-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548595
 ] 

Davor Hrg commented on TAPESTRY-1958:
-------------------------------------

Am I missing something here,
that example is the same as from the docs...

My point is to add a working example for a situation where user
is overiding specific service with a specific handcoded decorator.
The usage in this case is to add a specific functionality and not intercepting
method calls for logging and transaction demarcation.


the example for general purpose decorator is in docs already (Logging decorator)



> aditional example for service decorators
> ----------------------------------------
>
>                 Key: TAPESTRY-1958
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1958
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: Documentation, tapestry-ioc
>    Affects Versions: 5.0.6
>            Reporter: Davor Hrg
>             Fix For: 5.0.7
>
>
> documentation for decorating services should have an additional example
> somethig like this for situations where we are decorating a specific service,
> and not using some general decorator factory
>     public static ComponentMessagesSource 
> decorateComponentMessagesSource(Object delegate, Logger logger){
>         return new ComponentMessagesSourceDecorator((ComponentMessagesSource) 
> delegate,logger);
>     }
> this should be documented because the decorator is ignored if above is 
> chenged this way
> (this is somehow more logical than above but doesn't work)
>     public static ComponentMessagesSource 
> decorateComponentMessagesSource(ComponentMessagesSource delegate, Logger 
> logger){
>         return new ComponentMessagesSourceDecorator(delegate,logger);
>     }
> I think that the second sample caused exceptions in earlier versions....
> (the exception was even more misleading)
> of course, if not too much trouble, tapestry ioc could be modified so that 
> the second example works as well

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to