[ 
https://issues.apache.org/jira/browse/TAPESTRY-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573105#action_12573105
 ] 

Andreas Andreou commented on TAPESTRY-2201:
-------------------------------------------

Fixed - nice catch, thx!

> LabeledPropertySelectionModel.isDisabled ignores underlying model
> -----------------------------------------------------------------
>
>                 Key: TAPESTRY-2201
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2201
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Core Components
>    Affects Versions: 4.1, 4.1.1, 4.1.2, 4.1.3, 4.1.5
>            Reporter: Daniel Caldeweyher
>            Assignee: Andreas Andreou
>            Priority: Minor
>             Fix For: 4.1.6
>
>
> LabeledPropertySelectionModel.isDisabled only looks at the label, but not the 
> underlying model.
> public boolean isDisabled(int index) {
>       return index == 0 && _option == null;
> }
> should be replaced with:
> public boolean isDisabled(int index) {
>       return index == 0 ? _option == null : _model.isDisabled(index - 1);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to