The name @Property was just because i see for some time now people pushing for properties support in java generaly...
The feature it self was appealing to me, the name of the annotation was not that important. I even like @GenerateAccessors more than @Property since it is more descriptive on what will happen... maybe I ve put the patch in wrong JIRA, I wasn't trying to add support for exposing injections... I responded to a JIRA that was about exposing @Persist, but my patch was realy doing just about what you did here I added @Property annotation and made changes to InternalClassTransformer so it can be combined with other annotations. ... but never mind all that :) ... @GenerateAccessors work fine and I've removed my patch localy and refactored the code to use it instead of @Property... Davor Hrg On 3/2/08, Howard Lewis Ship <[EMAIL PROTECTED]> wrote: > I appreciated your patch to automatically expose injections & such as > properties, but I strongly believe that any addition to the > component's public API should be explicit, thus @GenerateAccessors. > The desire to be explicit about API goes further for components where > templates may include property expressions that reference properties, > and (being outside Java code) you can too easily break things by > refactoring. The @GenerateAccessors annotation serves as a reminder > to track down references in the template. > > On Sun, Mar 2, 2008 at 10:28 AM, Davor Hrg <[EMAIL PROTECTED]> wrote: > > just tried it,... works like a charm :) > > > > Davor Hrg > > > > > > On 3/2/08, Howard Lewis Ship <[EMAIL PROTECTED]> wrote: > > > Oops. Accidentally reformatted some code. > > > > > > On Sun, Mar 2, 2008 at 9:21 AM, <[EMAIL PROTECTED]> wrote: > > > > Author: hlship > > > > Date: Sun Mar 2 09:21:16 2008 > > > > New Revision: 632791 > > > > > > > > URL: http://svn.apache.org/viewvc?rev=632791&view=rev > > > > Log: > > > > TAPESTRY-2216: Add a @GenerateAccessors annotation for fields to > > create a getter and setter method > > > > > > > > Added: > > > > > > tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/annotations/GenerateAccessors.java > > > > > > tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/internal/transform/GenerateAccessorsWorker.java > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > -- > Howard M. Lewis Ship > > Creator Apache Tapestry and Apache HiveMind > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
