[ 
https://issues.apache.org/jira/browse/TAPESTRY-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580561#action_12580561
 ] 

Howard M. Lewis Ship commented on TAPESTRY-2247:
------------------------------------------------

I this really an issue?  In a typical case, the commit will occur on a context 
that has no outstanding issues.

Ah, I see, the issue is with partial updates that are invalid.  I think we need 
a larger strategy for handling this; a loose coupling between Form and the 
hibernate support so that the transaction can be rolled back, or marked 
rollback-only.  Currently, the best option is to supply an onFailure() event 
handler to roll the transaction back.

> Don't commit the transaction automatically at the end of the request
> --------------------------------------------------------------------
>
>                 Key: TAPESTRY-2247
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2247
>             Project: Tapestry
>          Issue Type: Bug
>          Components: tapestry-hibernate
>    Affects Versions: 5.0.10
>            Reporter: Dan Adams
>            Assignee: Dan Adams
>
> On thread cleanup, the Session should be flushed not committed. If people 
> want to commit changes they should explicitly do so but having the 
> transaction committed automatically can lead to some very mysterious changing 
> of the data. In my experience, having the transaction committed automatically 
> does more harm than good.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to