The InjectPageWorker should use the ComponentSource service, rather than the
RequestPageCache
---------------------------------------------------------------------------------------------
Key: TAPESTRY-2342
URL: https://issues.apache.org/jira/browse/TAPESTRY-2342
Project: Tapestry
Issue Type: Improvement
Components: tapestry-core
Affects Versions: 5.0.11
Reporter: Howard M. Lewis Ship
Priority: Trivial
Currently, it generates Javassist code like:
add method: private com.parametrix.earth.pages.survey.SurveyDebug
_$read_inject_page_nextPage()
{
org.apache.tapestry.internal.structure.Page page =
_$requestPageCache.get("MyPage");
return (com.examples.pages.MyPage) page.getRootElement().getComponent();
}
But the less runtime generated code, the better (minutely faster, and easier to
debug), Using an injected ComponentSource, this would be more like:
return (om.examples.pages.MyPage) _$componentSource.getPage("MyPage");
Even in runtime generated code, Law of Demeter is still useful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
