OK. thanks.
Though I think that such a file asset fits to the core. In fact I got
some contacts who were really missing such a file asset.
But you certainly know better what should be core and not.
Howard Lewis Ship schrieb:
I hope to review the patch this week. As it is something that will not
be needed by most developers, I may not apply it as-is to core. In
fact, I'm thinking it should be part of the external tapx project.
On Sat, May 2, 2009 at 4:57 PM, manuel aldana <[email protected]> wrote:
Forgot to mention: To see how it looks from user side have a look at
AssetDemo.tml+java inside the integration test webapp app1/. I also added
file asset to IntegrationTests.asset().
manuel aldana schrieb:
This time for file-asset: https://issues.apache.org/jira/browse/TAP5-423.
Please review.
Open things are:
-For the start I introduced interface FileAssetAliasManager which has
exactly there same signature and semantics as ClasspathAliasManager. IMHO
ClasspathAliasManagerImpl and FileAssetAliasManagerImpl should implement the
same interface. What do you think?
-I used some error messages for the stack trace. Maybe they should be
extracted to the ServicesStrings.properties (which I haven't done yet)? What
is the convention of putting strings there. For all error messages which can
occur?
-...@since tag is marked with a todo and not filled yet.
thanks.
--
manuel aldana
[email protected]
software-engineering blog: http://www.aldana-online.de
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
--
manuel aldana
[email protected]
software-engineering blog: http://www.aldana-online.de
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
