I would like to put these changes in a later release. As Ulrich already pointed out we should release 5.1.0.6 asap. It is only possible iff we backport already fixed issues. If we would fix the both issues you suggested somebody else could suggest some other issues. This would delay the release.
On Mon, Nov 23, 2009 at 1:44 PM, Ulrich Stärk <[email protected]> wrote: > Oh, I missed the one for TAP5-834. I can't judge it though, since I'm not > familiar with that code or it's implications. > > On second thought, TAP5-774 will probably not make it into 5.1.0.6 due to > another reason: It would break existing applications relying on Tapestry > encoding & as &. I feel that this shouldn't be in a bugfix release. > > Uli > > Am 23.11.2009 13:08 schrieb Andy Blower: > > >> TAP5-834 does have a patch that I added quite a long time ago. I went to >> the >> trouble so it would make it in the next release. It's disappointing that >> it's not even been looked at, or noticed even. >> >> TAP5-773 is a single line change as detailed in the bug report - I didn't >> think it warranted a patch file, but I can create one if neccessary. As >> for >> a test for 773, I'm really not familiar enough with T5's tests and test >> systems to even know where to start. I may be able to do it with some >> guidance, like if someone pointed me at where the test for this code is >> located. >> >> >> >> Ulrich Stärk wrote: >> >>> TAP5-815 will be in the 5.1.0.6 release, Robert is just holding it open >>> for the moment. >>> >>> The other two don't have patches yet and since 5.1.0.6 should be >>> realeased >>> as soon as possible due to TAP5-815, I doubt that they will make it into >>> the release. If you >>> provide a patch and a test for TAP5-773 though, I'm sure that one of the >>> committers will look at it. >>> Shouldn't be that hard since you already have an idea how to fix that. >>> >>> Cheers, >>> >>> Uli >>> >>> Am 23.11.2009 11:50 schrieb Andy Blower: >>> >>>> As one of the voices calling for a 5.1 bug fix release I thought I'd >>>> take >>>> a >>>> peek at the dev list. Glad to see things are moving, but a bit >>>> disappointed >>>> not to see some key (IMO) bugs not on the list. >>>> >>>> Can I suggest that these are added: >>>> >>>> https://issues.apache.org/jira/browse/TAP5-834 >>>> https://issues.apache.org/jira/browse/TAP5-773 >>>> >>>> and if possible: >>>> >>>> https://issues.apache.org/jira/browse/TAP5-815 >>>> >>>> >>>> Thanks, >>>> >>>> Andy. >>>> >>>> >>>> Ulrich Stärk wrote: >>>> >>>>> For the 5.1.0.6 release, I'd suggest to backport the fixes for the >>>>> following issues: >>>>> >>>>> Bugs: >>>>> >>>>> https://issues.apache.org/jira/browse/TAP5-913 >>>>> https://issues.apache.org/jira/browse/TAP5-779 >>>>> https://issues.apache.org/jira/browse/TAP5-767 >>>>> https://issues.apache.org/jira/browse/TAP5-755 >>>>> https://issues.apache.org/jira/browse/TAP5-749 >>>>> https://issues.apache.org/jira/browse/TAP5-748 >>>>> https://issues.apache.org/jira/browse/TAP5-734 >>>>> https://issues.apache.org/jira/browse/TAP5-719 >>>>> https://issues.apache.org/jira/browse/TAP5-714 >>>>> https://issues.apache.org/jira/browse/TAP5-711 >>>>> >>>>> Improvements: >>>>> >>>>> https://issues.apache.org/jira/browse/TAP5-912 >>>>> https://issues.apache.org/jira/browse/TAP5-814 >>>>> https://issues.apache.org/jira/browse/TAP5-764 >>>>> https://issues.apache.org/jira/browse/TAP5-756 >>>>> https://issues.apache.org/jira/browse/TAP5-138 >>>>> >>>>> I already began to integrate the fixes to the 5.1.0.x-dev branch and >>>>> will >>>>> provide a patch covering those when I'm done. >>>>> >>>>> Uli >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: [email protected] >>>>> For additional commands, e-mail: [email protected] >>>>> >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >>> >>> >> > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Best regards, Igor Drobiazko
