Howard Lewis Ship wrote:
Interesting; I would think that when there's a '?' in the inocming
request, we should simply not attempt to create a relative URL. Is
that what's in your patch?
I did not change anything on the absolute or reletive URL side of things. All my patch does (besides adding a test) is:

-        String sep = "?";
+        String sep = absoluteURI.indexOf("?") > 0 ? "&" : "?";

making sure the first parameter added uses an & in stead of a ? when parameters are already on the absoluteURI passed in to the LinkImpl.

Cheers,
Joost
On Sat, Nov 28, 2009 at 12:20 PM, Joost Schouten (ml)
<[email protected]> wrote:
When calling toUri on the LinkImpl the parameters are added in a way where
they will always start with a "?". Obvisouly resulting in an invalid URL
with two ?'s when the base uri already has parameters in it.

I have created https://issues.apache.org/jira/browse/TAP5-937 and added a
patch (with test) for this problem.

I hope it will be included soon so I don't have to run my own patched
version.

Cheers,
Joost

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]







---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to