Should have said; this is just for logging to the console (or as configured
in log4j.properties, logback.xml, or whatever).

On Fri, Jun 4, 2010 at 12:17 PM, Josh Canfield <[email protected]>wrote:

> >> I can see this filter being part of Tapestry, but only used (by default)
> >> when in development mode (not production mode).  Thoughts?
> >
> > There's no reason to not add it. Just provide a symbol for turning it on
> and
> > off and another for the log location (if they don't exist yet).
>
> Seems useful. The only reason I'd hesitate adding things like this is
> that it seems pretty trivial to implement and I'm a fan of a lean core
> that makes these things trivial! Inevitably someone is going to want
> to bulk it out with features to enhance the format, or limit which
> pages are logged or include session variables or whatever.
>
> Anyway, this seems like an enhanced Timing Filter from the maven
> archetype (which I actually use in production slightly modified to
> report long running page renders) and maybe it makes a good example in
> the docs for how to create a simple filter.
>
> If it makes it in to the core then definitely use a new symbol for
> enabling and disabling, but shouldn't we leave the logging location up
> to the log implementation?
>
> Josh
>
> On Fri, Jun 4, 2010 at 11:40 AM, Thiago H. de Paula Figueiredo
> <[email protected]> wrote:
> > On Fri, 04 Jun 2010 15:30:36 -0300, Howard Lewis Ship <[email protected]>
> > wrote:
> >
> >> I can see this filter being part of Tapestry, but only used (by default)
> >> when in development mode (not production mode).  Thoughts?
> >
> > There's no reason to not add it. Just provide a symbol for turning it on
> and
> > off and another for the log location (if they don't exist yet).
> >
> > --
> > Thiago H. de Paula Figueiredo
> > Independent Java, Apache Tapestry 5 and Hibernate consultant, developer,
> and
> > instructor
> > Owner, Ars Machina Tecnologia da Informação Ltda.
> > http://www.arsmachina.com.br
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [email protected]
> > For additional commands, e-mail: [email protected]
> >
> >
>
>
>
> --
> --
> http://www.bodylabgym.com - a private, by appointment only, one-on-one
> health and fitness facility.
> --
> http://www.ectransition.com - Quality Electronic Cigarettes at a
> reasonable price!
> --
> TheDailyTube.com. Sign up and get the best new videos on the internet
> delivered fresh to your inbox.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>


-- 
Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to learn
how I can get you up and productive in Tapestry fast!

(971) 678-5210
http://howardlewisship.com

Reply via email to