When I see advise code that is looking for specific names of methods or casting parameters to specific types ... that's a case where it should be a decorator, not advice. Advice is meant for cases that are distinguished independent of those factors, typically by a method (or parameter) annotation.
On Mon, Aug 9, 2010 at 1:33 PM, Igor Drobiazko <[email protected]> wrote: > I didn't use decorate methods for a while. I'm using advise methods and have > the feeling that advise methods are the equivalent subsitute for decorate > methods. Also documentation is telling that decorate methods have been > replaced by advise methods. But it looks like they still are needed. > > On Mon, Aug 9, 2010 at 10:15 PM, Howard Lewis Ship <[email protected]> wrote: > >> What's the replacement for decoration methods? Service advice methods >> are close, but fill a different niche (i..e, when the service >> interface isn't known). I use decorate methods now when I'm changing >> the behavior of a known service (i.e., I know the service interface at >> build time), and advice methods for more general work (usually driven >> by annotations, and in an interface agnostic manner). >> >> On Mon, Aug 9, 2010 at 12:44 PM, Igor Drobiazko >> <[email protected]> wrote: >> > Hi all, >> > >> > I'm going to fix the https://issues.apache.org/jira/browse/TAP5-1232 by >> > reintroducing the injection of service ids into decorate methods in order >> > too make upgrade to 5.2 easier. The fix will affect only decorate >> methods. >> > Furthermore I would like to deprecate decorate methods by writing a note >> in >> > the documentation and logging a message at info level. Starting from 5.3 >> I >> > would remove the decorate methods. >> > >> > Any objections? >> > >> > -- >> > Best regards, >> > >> > Igor Drobiazko >> > http://tapestry5.de >> > >> >> >> >> -- >> Howard M. Lewis Ship >> >> Creator of Apache Tapestry >> >> The source for Tapestry training, mentoring and support. Contact me to >> learn how I can get you up and productive in Tapestry fast! >> >> (971) 678-5210 >> http://howardlewisship.com >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > > -- > Best regards, > > Igor Drobiazko > http://tapestry5.de > -- Howard M. Lewis Ship Creator of Apache Tapestry The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast! (971) 678-5210 http://howardlewisship.com --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
