I'll soon have the power to check this in. There are two places that I'd like to get eyes on because they involve changes to public interfaces.
Thanks, Josh http://codereview.appspot.com/2140047/diff/17001/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/ObjectLocator.java File tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/ObjectLocator.java (right): http://codereview.appspot.com/2140047/diff/17001/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/ObjectLocator.java#newcode83 tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/ObjectLocator.java:83: <T> T getService(Class<T> serviceInterface, Type genericType); Change to public interface. It could possibly be moved into a GenericObjectLocator. Is this an interface that people actively implement? http://codereview.appspot.com/2140047/diff/17001/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/services/MasterObjectProvider.java File tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/services/MasterObjectProvider.java (right): http://codereview.appspot.com/2140047/diff/17001/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/services/MasterObjectProvider.java#newcode58 tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/services/MasterObjectProvider.java:58: <T> T provide(Class<T> objectType, Type genericType, AnnotationProvider annotationProvider, ObjectLocator locator, boolean required); Modified public interface; Changed method signature instead of adding a new signature. Tapestry Core uses it in DefaultInjectionProvider and IOC uses it in the Registry. Is there user code out there that uses this? http://codereview.appspot.com/2140047/ --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
