Okay, I can't use that code review tool. Maybe it is because I use git
and the rest of the world (except Howard?) uses svn?
Anyway, you can pull from my git repository, it's conveniently located
downstairs in the living room.
git://hetdiana.homeip.net/tapestry5.git
I've created branch "iocmod1" and branch "iocmod2" and branch "iocmod3"
and branch "hibmod"
iocmod1 adds dynamic services
iocmod2 adds dynamic contributions
iocmod3 adds getService(serviceInterface, markers) to ObjectLocator
(what is better, Set<Class<? extends Annotation>> or Set<Class> ?)
hibmod is a work in progress, for the next couple of hours at least it
will contain my changes to tapestry-hibernate-core, without integration
testing.
If you pull branch iocmod3 you get all proposed changes to ioc core and
if you pull branch iocmod2 you get only those that don't appear to break
test cases in tapestry-core and perhaps other projects
They are rebased upon the latest trunk (including Igor's change on
@Startup annotations).
I have yet to update the diff files in JIRA, I'll get to that later.
What is the best course of action? Change to using SVN and upload SVN
diff files? I kinda like git because it lets me do all the branching and
merging with ease.
Op 19-10-2010 20:13, Tom van Dijk schreef:
I used the git from Howard. I'll check the code review tool later
today/tomorrow.
On Tue, 19 Oct 2010 08:51:19 -0700, Josh Canfield<[email protected]>
wrote:
I was trying to take a look at your patch but I couldn't get a good
merge.
Are you synch'd to the trunk?
I found the rietveld code review tool helpful (
http://codereview.appspot.com/), would you consider putting your patch
there
so we can get a better look without having to download and install the
patch? I've created a tapestry5 project there.
On 19 Oct 2010 03:19, "Tom van Dijk"<[email protected]> wrote:
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
