I think this idea is good. There are even more extra methods: clickLink, clickSubmit and submitForm.
What about the name xxxAndReturnResponse()? For example renderPage() and renderPageAndReturnResponse(), clickLink() and clickLinkAndReturnResponse(). On Tue, Nov 9, 2010 at 10:58 PM, Andreas Andreou <[email protected]> wrote: > How about an extra method in PageTester for those that want to get > the whole response (instead of just the document)... > > So, something like > Response renderResponse(String pageName) > It could reuse most of the PageTester.renderPage code > > On Tue, Nov 9, 2010 at 23:31, Igor Drobiazko <[email protected]> > wrote: > > So, I'm almost done. The only remaining issues are responses that don't > > result in a Document. For example response.sendError(int, String), > > response.setStaus(int) or response.senRedirect(String). As PageTester > always > > returns a Document, there is a challenge. Changing the signature of > > PageTester's methods is not an option, so we need a way to return some > > special Documents. > > > > There are two alternatives. Either we create subclasses for Document > (like > > RedirectDocument, StatusDocumen, HttpErrorDocument) or we just create a > > Document whose markup is just a string (error, statusMsg or redirectUrl). > > > > Any objections? Any thoughts? > > > > On Tue, Nov 9, 2010 at 6:58 PM, Igor Drobiazko <[email protected] > >wrote: > > > >> I'll try to commit soon. > >> > >> > >> On Tue, Nov 9, 2010 at 6:45 PM, Howard Lewis Ship <[email protected] > >wrote: > >> > >>> On Tue, Nov 9, 2010 at 9:23 AM, Igor Drobiazko < > [email protected] > >>> >wrote: > >>> > >>> > I was going to enhance the TestableReponse. Too many methods are not > >>> usable > >>> > right now as they throw "not yet implemented" exception. > >>> > > >>> > When do you want to create the release? > >>> > > >>> > > >>> Later this week, if not sooner. I really want the final release in > 2010! > >>> > >>> > >>> > >>> > On Tue, Nov 9, 2010 at 6:01 PM, Howard Lewis Ship <[email protected]> > >>> > wrote: > >>> > > >>> > > I'm about ready to crank out 5.2.3, which I think is likely to > become > >>> the > >>> > > GA. Anybody sitting on a last minute bug fix or change? > >>> > > > >>> > > -- > >>> > > Howard M. Lewis Ship > >>> > > > >>> > > Creator of Apache Tapestry > >>> > > > >>> > > The source for Tapestry training, mentoring and support. Contact me > to > >>> > > learn > >>> > > how I can get you up and productive in Tapestry fast! > >>> > > > >>> > > (971) 678-5210 > >>> > > http://howardlewisship.com > >>> > > > >>> > > >>> > > >>> > > >>> > -- > >>> > Best regards, > >>> > > >>> > Igor Drobiazko > >>> > http://tapestry5.de > >>> > > >>> > >>> > >>> > >>> -- > >>> Howard M. Lewis Ship > >>> > >>> Creator of Apache Tapestry > >>> > >>> The source for Tapestry training, mentoring and support. Contact me to > >>> learn > >>> how I can get you up and productive in Tapestry fast! > >>> > >>> (971) 678-5210 > >>> http://howardlewisship.com > >>> > >> > >> > >> > >> -- > >> Best regards, > >> > >> Igor Drobiazko > >> http://tapestry5.de > >> > > > > > > > > -- > > Best regards, > > > > Igor Drobiazko > > http://tapestry5.de > > > > > > -- > Andreas Andreou - [email protected] - http://blog.andyhot.gr > Tapestry PMC / Tacos developer > Open Source / JEE Consulting > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Best regards, Igor Drobiazko http://tapestry5.de
