I'm officially Dragan's mentor but the rest of committers should really take a look at Dragan's excellent work if you can just spare a few cycles for it. The demo site (http://dragansah.com/contextmenu/) Dragan put together makes it easy to track the project status even if you don't have time to dive into the code. We already talked about the items via Skype but a few quick comments below..
On Sun, May 29, 2011 at 1:51 PM, [email protected] <[email protected]> wrote: > 1. Two mixins: ContextMenu and ContextMenuAjax or merge them in one > mixin? It doesn't cost any more to use separate mixins for the user so probably makes sense to keep as is for now. > 2. Is the concept of advising GridCell (actualy AbstractPropertyOutput<http://tapestry.apache.org/tapestry5/apidocs/org/apache/tapestry5/corelib/base/AbstractPropertyOutput.html#renderPropertyValue(org.apache.tapestry5.MarkupWriter, > java.lang.String)>) ok? Its clear that we cannot implement support of the > t5 grid without an advice or I'm I wrong? That's the way and it didn't seem too bad at all, but if it'd be possible to implement it better by making a small, generic and backwards compatible enhancement to GridCell, I think that'd be preferable in the long run, just because there's some performance penalty whenever using an advice, and an AbstractPropertyOutput gets used a lot. > 5. The contextmenu is rendered after the component and there is a bit of > The quirk is that the contextmenu forces the render of the conainer's > clientId (if it is a t5 ClientElement), and uses it to set a javascript > event oncontextmenu on it using the id. If the component is not a t5 > ClientElement (t5 Label for example), than this javascript is applied for > getting the client element in js: $('contextMenuId').previousSibling. This > code assumes that the parent component is only one html element (div or > similar), but this is not the case for example the t5 TextField which > renders a trailing icon. Luckily the TextField is covered because it is a Seems to me it's quite fine to require ClientElement in that case. Kalle --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
