Hi, On Wed, Jul 6, 2011 at 10:16 AM, Taha Hafeez <[email protected]>wrote:
> Hi Dragan, > > On Wed, Jul 6, 2011 at 1:21 PM, [email protected] < > [email protected]> wrote: > > > Hi Taha, > > I was looking at the new tests and didn't figure out how to update > multiple > > zones but not the zone triggering the ajax. > > > > This corresponds to the scenario when you return a MultiZoneUpdate not > > containig the zone triggering the ajax. I have used this many many times > > when a component renders a dummy zone and a containing page or, component > > provides the multiZoneUpdate as a result to a custom event that in the > end > > does not contain the zone triggering the update. > > > > > I have not come across such a scenario so I didn't include it. A way to > take > care of this case that I can think of is returning the ZoneUpdater instance > which can be handled in the same way MultiZoneUpdate is. (Actually I just > used the code from MultiZoneUpdateEventResultProcessor in > ZoneUpdaterProcessorImpl) > What do you say ? OK, that's great I wasn't aware because it was not in the test cases. > > > > > Also, I didn't saw tests for ZoneUpdater.add(String zoneId, Object > > renderer) or have I missed something. > > > > add(ClientBodyElement) calls add(String,Object) internally so I didn't > include it. Yes, can add a test for blocks which will include that method > too. > Awsome. Cheers, Dragan Sahpaski > > > > Cheers, > > Dragan Sahpaski > > > > > Thanks for evaluating/analyzing > > regards > Taha > > > > > > > > On Wed, Jul 6, 2011 at 9:26 AM, Taha Hafeez (JIRA) <[email protected]> > > wrote: > > > > > > > > [ > > > > > > https://issues.apache.org/jira/browse/TAP5-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > > ] > > > > > > Taha Hafeez updated TAP5-1476: > > > ------------------------------ > > > > > > Attachment: zone-updater.patch > > > > > > Patch which injects a ZoneUpdater into the Environment. The processing > is > > > done by ZoneUpdaterProcessor. Does a modification to > > > AjaxComponentEventRequestHandler.java > > > > > > > Deprecate MultiZoneUpdate, replace with an injectable service to > > collect > > > zone updates > > > > > > > > > > ------------------------------------------------------------------------------------- > > > > > > > > Key: TAP5-1476 > > > > URL: https://issues.apache.org/jira/browse/TAP5-1476 > > > > Project: Tapestry 5 > > > > Issue Type: Improvement > > > > Components: tapestry-core > > > > Affects Versions: 5.3 > > > > Reporter: Howard M. Lewis Ship > > > > Attachments: zone-updater.patch > > > > > > > > > > > > MultiZoneUpdate presumes that there's a single place where all the > zone > > > to be updated are known. This is not necessarilly the case. > > > > I'd like to see something like: > > > > @Inject > > > > private ZoneUpdater zoneUpdater(); > > > > Object onSuccess() > > > > { > > > > zoneUpdater.update("foo", fooBlock); > > > > zoneUpdater.update("bar", barBlock); > > > > return myZone.getBody(); > > > > } > > > > The main point here is that different event handlers would all be > able > > to > > > invoke ZoneUpdater.update() . > > > > This would also allow a single response to render main content (for > the > > > requesting Zone on the client) plus zone updates to named zones. > > > > > > -- > > > This message is automatically generated by JIRA. > > > For more information on JIRA, see: > > http://www.atlassian.com/software/jira > > > > > > > > > > > >
