Hi Denis, I have some concerns about your patch.
1) The Apache's official source control system is Subversion. I'm not sure if git patches may be applied to SVN. Your patch will be more likely applied if you provide it SVN's diff. 2) I think your patch can lead to CME. Imagine that fireElementDidStart() starts iterating exactly when the invocation of removeListener() method is currently between lines: listeners = CollectionFactory.newList(listeners); and listeners.remove(listener); Regards On Tue, Jul 19, 2011 at 11:53 AM, Denis Stepanov <[email protected]>wrote: > Hi all, > > I had noticed that in MarkupWriterImpl every time when element event > start/end is fired, collection of listeners is recreated, probably to > prevent CME, better would be recreate it only when it is modified, see the > issue with a patch: https://issues.apache.org/jira/browse/TAP5-1532. > > Denis -- Best regards, Igor Drobiazko http://tapestry5.de
