That's an interesting idea, I don't know why it didn't occur to me. I am concerned that the JVM might discard page instances too often when memory gets tight.
I wouldn't have an objection to switching the PageCacheImpl over to using soft references .... it would also help with Google App Engine compatibility. Is that something you might want to take on? On Thu, Sep 8, 2011 at 10:45 AM, Kalle Korhonen <[email protected]> wrote: > On Thu, Sep 8, 2011 at 10:08 AM, Howard Lewis Ship <[email protected]> wrote: >> On Thu, Sep 8, 2011 at 9:49 AM, Josh Canfield <[email protected]> wrote: >>> Currently we can only control the interval, via >>> SymbolConstants.PAGE_SOURCE_CHECK_INTERVAL. >>> I'd prefer this service didn't run at all. >> Maybe a symbol to configure this behavior, i.e, >> "tapestry.page-cache-janitor-enabled" with default "true" > > The periodicExecutor service is great, but I just don't agree at all > that the core should use it by default. I would much prefer the > default behavior for purging unused pages was implemented with > SoftReferences instead of a periodic clean up. Periodic execution > prevents a modern virtualized environment to release unused resources > properly, far beyond what's happening within a single Tapestry > application. > > Kalle > > >>> Also, it logs with: >>> org.apache.tapestry5.ioc.services.TapestryIOCModule.PeriodicExecutor >>> >>> Which means I can only control logging for the entire >>> PeriodicExecutor, not the page source janitor. >> >> True; the PE logs the description of the job as it executes it. >> >>> >>> Josh >>> >>> On Thu, Sep 8, 2011 at 8:47 AM, Howard Lewis Ship <[email protected]> wrote: >>>> This is why you have control over your log4j (or whatever) configuration. >>>> >>>> On Wed, Sep 7, 2011 at 6:21 PM, Josh Canfield <[email protected]> >>>> wrote: >>>>> Agreed. This should also probably be off by default. >>>>> On Sep 7, 2011 6:07 PM, "Lenny Primak" <[email protected]> wrote: >>>>>> Executing job #1 (PagePool cleanup) >>>>>> >>>>>> This prints every 15 minutes and fills up log. >>>>>> >>>>>> Thanks >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: [email protected] >>>>>> For additional commands, e-mail: [email protected] >>>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> Howard M. Lewis Ship >>>> >>>> Creator of Apache Tapestry >>>> >>>> The source for Tapestry training, mentoring and support. Contact me to >>>> learn how I can get you up and productive in Tapestry fast! >>>> >>>> (971) 678-5210 >>>> http://howardlewisship.com >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >> >> >> >> -- >> Howard M. Lewis Ship >> >> Creator of Apache Tapestry >> >> The source for Tapestry training, mentoring and support. Contact me to >> learn how I can get you up and productive in Tapestry fast! >> >> (971) 678-5210 >> http://howardlewisship.com >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Howard M. Lewis Ship Creator of Apache Tapestry The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast! (971) 678-5210 http://howardlewisship.com --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
