+1 for keeping the @Override annotations. On Fri, Jan 27, 2012 at 12:48 PM, Howard Lewis Ship <[email protected]> wrote: > I'll have to check how I have IDEA set up; it was inserting those. > @Override on JDK 1.5 is different than 1.6 ... for 1.6 it also means > implementing an interface method, rather than strictly being an > override of a base class method. > > http://stackoverflow.com/questions/94361/when-do-you-use-javas-override-annotation-and-why > > On Fri, Jan 27, 2012 at 12:20 AM, <[email protected]> wrote: >> Author: uli >> Date: Fri Jan 27 08:20:05 2012 >> New Revision: 1236574 >> >> URL: http://svn.apache.org/viewvc?rev=1236574&view=rev >> Log: >> nothing to override here... >> >> Modified: >> >> tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java >> >> Modified: >> tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java >> URL: >> http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java?rev=1236574&r1=1236573&r2=1236574&view=diff >> ============================================================================== >> --- >> tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java >> (original) >> +++ >> tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java >> Fri Jan 27 08:20:05 2012 >> @@ -39,7 +39,6 @@ public class OperationAdvisorImpl implem >> { >> return new Runnable() >> { >> - @Override >> public void run() >> { >> invocation.proceed(); >> @@ -56,7 +55,6 @@ public class OperationAdvisorImpl implem >> this.description = description; >> } >> >> - @Override >> public void advise(MethodInvocation invocation) >> { >> tracker.run(description, toRunnable(invocation)); >> @@ -72,7 +70,6 @@ public class OperationAdvisorImpl implem >> this.format = format; >> } >> >> - @Override >> public void advise(MethodInvocation invocation) >> { >> Object[] parameters = extractParameters(invocation); >> @@ -97,7 +94,6 @@ public class OperationAdvisorImpl implem >> } >> } >> >> - @Override >> public void addOperationAdvice(MethodAdviceReceiver receiver) >> { >> for (Method m : receiver.getInterface().getMethods()) >> @@ -114,7 +110,6 @@ public class OperationAdvisorImpl implem >> } >> } >> >> - @Override >> public MethodAdvice createAdvice(String description) >> { >> assert InternalUtils.isNonBlank(description); >> >> > > > > -- > Howard M. Lewis Ship > > Creator of Apache Tapestry > > The source for Tapestry training, mentoring and support. Contact me to > learn how I can get you up and productive in Tapestry fast! > > (971) 678-5210 > http://howardlewisship.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] >
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
