Yes, pleas correct any stupid name.

On Wed, Feb 13, 2013 at 4:16 PM, Bob Harner <[email protected]> wrote:

> A very minor issue: The "SEND_404_TO_UNWANTED_ACTIVATION_CONTEXT" name
> seems to miss the mark a bit.
>
> For consistency with other symbol names, maybe
> "UNKNOWN_ACTIVATION_CONTEXT_CHECK_ENABLED" ?
>
>
> http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/SymbolConstants.html
>
> On Wed, Feb 13, 2013 at 9:55 AM, Massimo Lusetti <[email protected]>
> wrote:
> > On Wed, Feb 13, 2013 at 3:36 PM, Ulrich Stärk <[email protected]> wrote:
> >
> > +1 on the idea, -1 on the implementation.
> >>
> >> In PageActivatorImpl you set send404 from the symbol but never check on
> it.
> >>
> >>
> > Right.
> > The patch is wrong, It's not PRODUCTION_MODE that has to be check
> > is SEND_404_TO_UNWANTED_ACTIVATION_CONTEXT... That's the honeypot for
> > everyone commenting the issue ;-)
> >
> > --
> > Massimo
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>


-- 
Massimo
http://meridio.blogspot.com

Reply via email to