It was working ok, but I still updated the patch and moved servlet container runner instance reference from private field to ITestContext attribute. Should be fine now.
On Wed, Apr 17, 2013 at 12:05 PM, Dmitry Gusev <[email protected]>wrote: > Massimo, > > you made me think it may not work as expected with multiple threads. > Not sure if its possible to launch multiple containers simultaneously > though, but if its possible this will not work as expected. > I will check this. > > > On Wed, Apr 17, 2013 at 12:00 PM, Dmitry Gusev <[email protected]>wrote: > >> The behavior wasn't changed, its just in previous versions shutdown was >> made from java.lang.Runnable wrapper which is now direct call to >> ServletContainerRunner.stop() >> >> I've added private field that holds reference to ServletContainerRunner >> instance >> so that I can get ServletContext from it, and I use this field's values in >> shutdown logic, so its basically the same. I could leave it as before but >> in this case we would hold two different references in different places to >> the same ServletContainerRunner object. >> >> >> On Wed, Apr 17, 2013 at 11:55 AM, Massimo Lusetti <[email protected]>wrote: >> >>> On Wed, Apr 17, 2013 at 9:13 AM, Dmitry Gusev <[email protected] >>> >wrote: >>> >>> I hope its not too late for 5.3.7 >>> > >>> > Can somebody review and apply the patch and test from >>> > https://issues.apache.org/jira/browse/TAP5-2107 please? >>> > Its really a tiny, but valuable improvement for me. >>> > >>> > >>> Hi Dimitry, >>> I've just scrolled down at your patch but it seems it slightly change >>> the >>> behavior of SeleniumTestCase during the shutdown phase, am I right? >>> >>> -- >>> Massimo >>> >> >> >> >> -- >> Dmitry Gusev >> >> AnjLab Team >> http://anjlab.com >> > > > > -- > Dmitry Gusev > > AnjLab Team > http://anjlab.com > -- Dmitry Gusev AnjLab Team http://anjlab.com
