I'd put in the @Inherited, assuming the code will honor it in a subclass.
On Thu, Sep 12, 2013 at 9:30 AM, Massimo Lusetti <[email protected]> wrote: > On Thu, Sep 12, 2013 at 5:56 PM, Howard Lewis Ship <[email protected]>wrote: > > I don't understand why you modified the PageCatalog and etc. pages; they >> are now just hosts for a Block that is rendered inside T5Dashboard. If you >> access them directly, it is just blank. >> >> > Right, that's an oversight. > > >> Also, why does @UnknownActivationContextCheck have a value() of >> boolean? Surely its just about the presence of the annotation or its >> absence. >> >> > You can configure the whole app to be strictly checked but a single page > which you don't care or need/want to behave differently, there's an > integration test app which does exactly that, I think I called it > activationctx2 > > >> Alternately, why is it not @Inherited? That would be useful, and might >> justify the value() attribute (to allow subclass to change the value). >> >> > It could be. I've never used subclasses in pages so I'm not used to think > in that terms. Should I add it? > > Cheers > -- > Massimo Lusetti > -- Howard M. Lewis Ship Creator of Apache Tapestry The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast! (971) 678-5210 http://howardlewisship.com
