It has been mentioned on other lists that there is concern that those contributing through GitHub may not know that they are contributing to the project, and that the contributed code will be licensed under AL2.0. The vast majority of projects on GitHub don't have a license at all, so that does not appear to be part of the culture of that site (vs Google Code where every project has to have a license). Contributing a patch through Jira, Bugzilla, or the email list is a stronger indication of acknowledgement of contribution. It was suggested that getting a confirmation, either through email or a comment on the request, would be a good thing to do.

Additionally, jclouds which is a TLP was pointed out as a project that is doing a lot of work through GitHub, but uses the ASF infrastructure as the official repository.
http://jclouds.apache.org/documentation/devguides/

On 11/02/2013 06:49 AM, Ulrich Stärk wrote:
We conduct our business in the open, on archived mailing lists, in our case on
[email protected] and not on Github or any other third-party platform 
where we do not control
the infrastructure, the content, and most importantly the continuous 
availability of what's been
discussed (archives). So no, we don't discuss pull requests on Github.

What we can do is enable notifications of pull requests to be sent to 
[email protected] where
we subsequently can discuss them. Do we want this?

Uli

On 2013-11-01 12:06, Dmitry Gusev wrote:
Uli,

as for license considerations there is a notice on the Spark readme, that
should suffice if I understand this right:
https://github.com/apache/incubator-spark#contributing-to-spark

You probably right about manually applied PRs... and they also closed by
https://github.com/asfgit account, which is something ASF specific.

Well, at least they hold discussions on that PRs right on GitHub.

So there's nothing we can do with this, right?


On Fri, Nov 1, 2013 at 2:24 PM, Ulrich Stärk <[email protected]> wrote:

Oh and the closed pull requests of the Spark projects are most likely due
to github closing them
automatically when a commit mentioning the request is made. Merging the
request has to be done
manually though.

Uli

On 2013-11-01 11:20, Ulrich Stärk wrote:
To my knowledge, github pull requests can't be accepted directly. What's
on Github is just a mirror
of our repo at git-wip.us.apache.org. Apache projects that "accept"
pull requests usually ask
developers to create regular patches which are incorporated the
traditional way: through patches.
This is also a license concern. Having a contributor bring a patch to us
makes sure that he really
is knowingly contributing under the Apache License.

Uli

On 2013-11-01 10:20, Dmitry Gusev wrote:
I'd really like to see GitHub Pull Requests accepted in tapestry.

I just googled and a first link pointed to apache project that do this,
so
this should be possible:

https://github.com/apache/incubator-spark

I can see they have pull requests and some of them were already
accepted.

I really think this will encourage more fixes from community and this
may
be really agile.

As you know GitHub supports integration with Travis CI (
https://travis-ci.org) and other tools that may contribute to Tapestry
development.

What do you think?



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]





---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to