The patch looks good to me. Thanks, Michael! On Mon, Oct 16, 2017 at 9:51 AM, Jochen Kemnade <jochen.kemn...@eddyson.de> wrote:
> Thanks for the patch and the reminder, Michael. > > I think that is is safe to apply the patch. > If mutiple threads arrive at the loader.loadClass(className) call at the > same time, the PlasticClassLoader's loadClass implementation will > synchronize anyway. > So, if there are no objections, I'll merge the patch into master later > this week. > > Jochen > > ----- Am 16. Okt 2017 um 12:30 schrieb Michael N. Mikhulya > m.mikhu...@gmail.com: > > > Hi, > > > > is it possible to apply patch from > > https://issues.apache.org/jira/browse/TAP5-2558 > > > > while we are in alfa stage? > > > > On Mon, Oct 16, 2017 at 12:02 PM, Jochen Kemnade < > jochen.kemn...@eddyson.de> > > wrote: > > > >> Hi, > >> > >> ----- Am 13. Okt 2017 um 23:20 schrieb Thiago H. de Paula Figueiredo > >> thiag...@gmail.com: > >> > Is there any struggle with backporting stuff for 5.4? I'd guess the > ASM > >> > upgrade > >> > was just updating the version. Was it? > >> > >> Basically yet. Since we repackage ASM under the Tapestry namespace, I > had > >> to extract the new sources, remove a package that we don't use, and > >> increase a method's invisibility (we have been doing that for a while). > >> But I don't know if ASM 6 is compatible with Java 6 (which we still > >> support in the 5.4 line). > >> > >> >> I've used 5.5-alpha-3 in production for several months now and have > not > >> >> encountered any regression issues. Has anyone else given it a try? > >> >> Also, does anyone else have some spare time to help finish the > release? > >> >> > >> > > >> > Next week is complicated for me, but the following one I can schedule > >> some > >> > time to help you. > >> > >> Great, let's make a public beta next week and see what needs to be done > >> for a final release. > >> > >> Jochen > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > >> For additional commands, e-mail: dev-h...@tapestry.apache.org > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > For additional commands, e-mail: dev-h...@tapestry.apache.org > > -- Thiago
