Hi Thiago, did I understand correctly that the most important tests are specific to ASM? Because in this case I can’t help unfortunately, but I can test it on newer Java versions if this would help?
Best, Rafael > On 2018-29-11, at 12:45 PM, Thiago H. de Paula Figueiredo > <thiag...@gmail.com> wrote: > > This error isn't related to the AMS 7 patch. It's a Selenium test helper > method used by a number of tests which fails intermittently. Pretty > annoying I'll try to fix this today. > > When this is fixed, I plan to release a beta. Is there anyone here who > could test this beta with Java 9, 10 or 11? Unfortunately, I don't have any > projects that could be used as a good test the ASM upgrade. > > On Thu, Nov 29, 2018 at 1:26 AM Hudson (JIRA) <j...@apache.org> wrote: > >> >> [ >> https://issues.apache.org/jira/browse/TAP5-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702671#comment-16702671 >> ] >> >> Hudson commented on TAP5-2588: >> ------------------------------ >> >> FAILURE: Integrated in Jenkins build tapestry-trunk-freestyle-java-9 #5 >> (See [https://builds.apache.org/job/tapestry-trunk-freestyle-java-9/5/]) >> TAP5-2588: upgrading from ASM 6 to 7 for Java 9+ support (thiago: rev >> 1c71aec760797c7dc595351639767ae4974b1b82) >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/AnnotationNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/InsnNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/TraceClassVisitor.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Type.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/signature/SignatureReader.java >> * (add) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/SymbolTable.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/VarInsnNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/Printer.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/MultiANewArrayInsnNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/Subroutine.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/CheckAnnotationAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/ModuleWriter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/JSRInlinerAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/AnnotationRemapper.java >> * (edit) gradle/wrapper/gradle-wrapper.properties >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/RemappingAnnotationAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/Interpreter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/InstructionAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/ModuleResolutionAttribute.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/TypeInsnNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/TryCatchBlockNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/ModuleOpenNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/signature/SignatureWriter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/InsnList.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/package.html >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/JumpInsnNode.java >> * (add) plastic/LICENSE-ASM-7_0.txt >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/SourceInterpreter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/AdviceAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/package.html >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/AnalyzerException.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/IincInsnNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/ModuleTargetAttribute.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/Textifier.java >> * (delete) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/SAXClassAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/TraceAnnotationVisitor.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Frame.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/SerialVersionUIDAdder.java >> * (delete) plastic/LICENSE-ASM-5_0.txt >> * (add) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/ClassTooLargeException.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/Remapper.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/ASMifiable.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/ModuleVisitor.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/LabelNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/Frame.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/TypeReference.java >> * (delete) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/SAXAnnotationAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/FieldInsnNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/CurrentFrame.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/ModuleRequireNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/TraceSignatureVisitor.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/LookupSwitchInsnNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/InnerClassNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/FieldNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/SimpleRemapper.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/ParameterNode.java >> * (edit) >> plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassImpl.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/TryCatchBlockSorter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/Textifiable.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/TraceFieldVisitor.java >> * (delete) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/package.html >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/LdcInsnNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Handle.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/ClassWriter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/BasicValue.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/TableSwitchGenerator.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/InvokeDynamicInsnNode.java >> * (add) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Symbol.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/MethodInsnNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/FieldWriter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/LocalVariableNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/SimpleVerifier.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/ModuleRemapper.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/RemappingFieldAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/AnalyzerAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/ModuleExportNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/TableSwitchInsnNode.java >> * (add) tapestry-ioc/src/test/resources/hibernate.cfg.xml >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Context.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/CheckClassAdapter.java >> * (delete) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/ASMContentHandler.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/TypePath.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/ByteVector.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/AnnotationWriter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/BasicInterpreter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/FrameNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/ClassNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/LocalVariableAnnotationNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/BasicVerifier.java >> * (add) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/MethodTooLargeException.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/CheckFieldAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/MethodWriter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Opcodes.java >> * (delete) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/SAXFieldAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/ClassReader.java >> * (add) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/ConstantDynamic.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/ModuleNode.java >> * (add) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Constants.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/signature/SignatureVisitor.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/LocalVariablesSorter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/Value.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/CheckModuleAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/ModuleProvideNode.java >> * (delete) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/Processor.java >> * (add) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/Util.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/ClassVisitor.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/RemappingSignatureAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/IntInsnNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/Analyzer.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/CheckMethodAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/AbstractInsnNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Label.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/StaticInitMerger.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/AnnotationVisitor.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/TraceModuleVisitor.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/MethodNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/RemappingClassAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/FieldVisitor.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/package.html >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/ASMifier.java >> * (delete) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Item.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/signature/package.html >> * (add) >> tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/Main.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/ModuleHashesAttribute.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/package.html >> * (delete) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/SAXCodeAdapter.java >> * (delete) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/SAXModuleAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/CheckSignatureAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/Method.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/TypeAnnotationNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Edge.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/SourceValue.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/GeneratorAdapter.java >> * (delete) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/asm-xml.dtd >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/FieldRemapper.java >> * (edit) >> plastic/src/main/java/org/apache/tapestry5/internal/plastic/InstructionBuilderImpl.java >> * (edit) plastic/build.gradle >> * (edit) >> plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassPool.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/SmallSet.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/TraceMethodVisitor.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/ClassRemapper.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/RemappingMethodAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Attribute.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Handler.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/CodeSizeEvaluator.java >> * (add) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/UnsupportedClassVersionException.java >> * (delete) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/SAXAdapter.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/MethodVisitor.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/package.html >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/LineNumberNode.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/SignatureRemapper.java >> * (edit) >> plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/MethodRemapper.java >> >> >>> Does not work with Java 9 >>> ------------------------- >>> >>> Key: TAP5-2588 >>> URL: https://issues.apache.org/jira/browse/TAP5-2588 >>> Project: Tapestry 5 >>> Issue Type: Bug >>> Components: plastic >>> Affects Versions: 5.4.3 >>> Reporter: Jochen Kemnade >>> Assignee: Bob Harner >>> Priority: Critical >>> Attachments: >> 0001-TAP5-2588-Upgrade-ASM-6.x-7.0.1-for-Java-11-support.patch >>> >>> >>> You cannot use Tapestry with Java 9 because of an outdated ASM version >> in plastic (5.0.4). AFAICT, we'll need to upgrade to 6.0. My attempt do do >> so results in a {{ClassCastException}} in >> {{org.apache.tapestry5.plastic.ArrayAttributeAnnotations.explicit values >> for array attributes}}. >>> {noformat} >>> java.lang.ClassCastException: [I cannot be cast to >> java.base/[Ljava.lang.Object; >>> at >> org.apache.tapestry5.internal.plastic.AbstractAnnotationBuilder$2.visitEnd(AbstractAnnotationBuilder.java:134) >>> at >> org.apache.tapestry5.internal.plastic.asm.tree.AnnotationNode.accept(AnnotationNode.java:284) >>> at >> org.apache.tapestry5.internal.plastic.asm.tree.AnnotationNode.accept(AnnotationNode.java:251) >>> at >> org.apache.tapestry5.internal.plastic.PlasticClassPool.createAnnotation(PlasticClassPool.java:307) >>> at >> org.apache.tapestry5.internal.plastic.PlasticClassPool$4.buildAnnotation(PlasticClassPool.java:286) >>> at >> org.apache.tapestry5.internal.plastic.PlasticClassPool$4.getAnnotation(PlasticClassPool.java:270) >>> at >> org.apache.tapestry5.internal.plastic.DelegatingAnnotationAccess.getAnnotation(DelegatingAnnotationAccess.java:42) >>> at >> org.apache.tapestry5.internal.plastic.PlasticClassImpl.getAnnotation(PlasticClassImpl.java:342) >>> at org.apache.tapestry5.plastic.ArrayAttributeAnnotations.explicit >> values for array attributes(ArrayAttributeAnnotations.groovy:27) >>> {noformat} >>> The {{AbstractAnnotationBuilder}} subclass tries to cast an {{int[]}} to >> an {{Object[]}}. >> >> >> >> -- >> This message was sent by Atlassian JIRA >> (v7.6.3#76005) >> > > > -- > Thiago --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
