I'm sorry, I didn't have a chance to test it locally yet with your patches.
On Thu, Dec 6, 2018 at 3:43 AM Dimitris Zenios <dimitris.zen...@gmail.com> wrote: > I dont think is the patch.all tests work fone on my pc.havr you tried > building locally? > > On Thu, 6 Dec 2018, 03:47 Thiago H. de Paula Figueiredo < > thiag...@gmail.com > wrote: > > > I've reverted these patches for now since they caused test failures: > > > > > https://builds.apache.org/job/tapestry-trunk-freestyle/lastCompletedBuild/testReport/ > > . > > Of course, we can merge them back later. > > > > On Sat, Dec 1, 2018 at 11:04 PM Dimitris Zenios < > dimitris.zen...@gmail.com > > > > > wrote: > > > > > Here are 3 more which they are more or less connected with JPA failing > / > > > disabled tests > > > > > > Order of applying is important > > > > > > Example if the 0001-fix-tomcat-runner-patch is not applied first then > JPA > > > JNDI test suite will fail > > > > > > On Sat, Dec 1, 2018 at 3:40 AM Dimitris Zenios < > > dimitris.zen...@gmail.com> > > > wrote: > > > > > >> One more > > >> > > >> Correct test for TAP5-2582 > > >> > > >> On Sat, Dec 1, 2018 at 1:56 AM Dimitris Zenios < > > dimitris.zen...@gmail.com> > > >> wrote: > > >> > > >>> Another one small fix > > >>> > > >>> On Sat, Dec 1, 2018 at 1:51 AM Dimitris Zenios < > > >>> dimitris.zen...@gmail.com> wrote: > > >>> > > >>>> Sure but lets get 5.5 out the door first. > > >>>> > > >>>> I have been going over the changes and i have some patches > available. > > >>>> > > >>>> First attached is the already mentioned issue with static interface > > >>>> methods > > >>>> > > >>>> > > >>>> > > >>>> On Sat, Dec 1, 2018 at 1:26 AM Thiago H. de Paula Figueiredo < > > >>>> thiag...@gmail.com> wrote: > > >>>> > > >>>>> On Fri, Nov 30, 2018 at 7:36 PM Dimitris Zenios < > > >>>>> dimitris.zen...@gmail.com> > > >>>>> wrote: > > >>>>> > > >>>>> > I have some ideas on that subject but lest get 5.5 out first and > > >>>>> continue > > >>>>> > on that afterwards > > >>>>> > > > >>>>> > > >>>>> Nice! Could you please start a new thread with your ideas? I'm > > curious > > >>>>> about them. :) > > >>>>> > > >>>>> > > >>>>> > > > >>>>> > On Fri, Nov 30, 2018 at 11:33 PM Thiago H. de Paula Figueiredo < > > >>>>> > thiag...@gmail.com> wrote: > > >>>>> > > > >>>>> > > Yeah, it would break webapps styled with Bootstrap 4 due to the > > >>>>> different > > >>>>> > > tagging. Maybe we (the Tapestry team or the community) could > come > > >>>>> up > > >>>>> > with a > > >>>>> > > separate library to do this. > > >>>>> > > > > >>>>> > > On Fri, Nov 30, 2018 at 7:30 PM Dimitris Zenios < > > >>>>> > dimitris.zen...@gmail.com > > >>>>> > > > > > >>>>> > > wrote: > > >>>>> > > > > >>>>> > > > Its not so huge my main concern is the backwards > compatibility > > >>>>> > > > > > >>>>> > > > On Fri, Nov 30, 2018 at 11:27 PM Thiago H. de Paula > Figueiredo > > < > > >>>>> > > > thiag...@gmail.com> wrote: > > >>>>> > > > > > >>>>> > > > > On Fri, Nov 30, 2018 at 6:45 PM Dimitris Zenios < > > >>>>> > > > dimitris.zen...@gmail.com > > >>>>> > > > > > > > >>>>> > > > > wrote: > > >>>>> > > > > > > >>>>> > > > > > Even though it might be irrelevant i was also thinking of > > >>>>> bootstrap > > >>>>> > > 4. > > >>>>> > > > > > > > >>>>> > > > > > > >>>>> > > > > Hmm, it would be nice, but I don't think it would be a > > >>>>> trivial, quick > > >>>>> > > > thing > > >>>>> > > > > to do. Any takers? :) > > >>>>> > > > > > > >>>>> > > > > > > >>>>> > > > > > > > >>>>> > > > > > On Fri, Nov 30, 2018 at 10:31 PM Dimitris Zenios < > > >>>>> > > > > > dimitris.zen...@gmail.com> > > >>>>> > > > > > wrote: > > >>>>> > > > > > > > >>>>> > > > > > > +1 > > >>>>> > > > > > > > > >>>>> > > > > > > On Fri, 30 Nov 2018, 22:28 Thiago H. de Paula > Figueiredo > > < > > >>>>> > > > > > > thi...@arsmachina.com.br wrote: > > >>>>> > > > > > > > > >>>>> > > > > > >> Hello! > > >>>>> > > > > > >> > > >>>>> > > > > > >> Since we now have a working build and ASM 7 supporting > > >>>>> Java 11, > > >>>>> > I > > >>>>> > > > was > > >>>>> > > > > > >> thinking of release a beta version so people could > test > > >>>>> it on > > >>>>> > > their > > >>>>> > > > > > >> own projects. What do you think? > > >>>>> > > > > > >> > > >>>>> > > > > > >> Cheers! > > >>>>> > > > > > >> -- > > >>>>> > > > > > >> Thiago H. de Paula Figueiredo > > >>>>> > > > > > >> > > >>>>> > > > > > >> > > >>>>> > > > > > >>>>> > --------------------------------------------------------------------- > > >>>>> > > > > > >> To unsubscribe, e-mail: > > >>>>> dev-unsubscr...@tapestry.apache.org > > >>>>> > > > > > >> For additional commands, e-mail: > > >>>>> dev-h...@tapestry.apache.org > > >>>>> > > > > > >> > > >>>>> > > > > > >> > > >>>>> > > > > > > > >>>>> > > > > > > >>>>> > > > > > > >>>>> > > > > -- > > >>>>> > > > > Thiago > > >>>>> > > > > > > >>>>> > > > > > >>>>> > > > > >>>>> > > > > >>>>> > > -- > > >>>>> > > Thiago > > >>>>> > > > > >>>>> > > > >>>>> > > >>>>> > > >>>>> -- > > >>>>> Thiago > > >>>>> > > >>>> > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > > > For additional commands, e-mail: dev-h...@tapestry.apache.org > > > > > > > > -- > > Thiago > > > -- Thiago
