On Thu, Jan 17, 2019 at 8:43 PM Balázs Palcsó <palcso.bal...@gmail.com> wrote:
> Hi, > Hello! > On master Jenkins seems to fail, but locally my build passes. > TestWithAnnotationsInServiceImplementation.persist_entities is a test that fails intermittently. We should probably try to make it pass reliably someday. > > I am not sure what the problem is, I don't see the button to trigger > jenkins build without a commit. > Have you logged in to Jenkins? I also committed the changes to 5.4.x branch, but it also fails due to some > reason which seems irrelevant to my changes. > Any insight? > Is there anything I should fix? > I've created the 5.4.x branch build but never actually spent time to make it work, so I wouldn't worry about your commits there. > > Thanks, > Balazs > > On Thu, 17 Jan 2019 at 20:03, Thiago H. de Paula Figueiredo < > thiag...@gmail.com> wrote: > > > On Thu, Jan 17, 2019 at 4:51 PM Balázs Palcsó <palcso.bal...@gmail.com> > > wrote: > > > > > Thanks Thiago, > > > > > > > You're welcome! > > > > > > > Everything seems to work. > > > Committed two fixes to master: > > > * https://issues.apache.org/jira/browse/TAP5-2075 > > > * https://issues.apache.org/jira/browse/TAP5-2606 > > > > > > Awesome! I've very happy to see you committing and fixing tickets not > even > > an hour after you were granted permissions to do that! :) > > > > > > > Shall I commit them to 5.4 branch too? > > > > > > > Please do it. Feel free to not do it if a simple git cherry-pick doesn't > > work outright. Thanks again! > > > > -- > > Thiago > > > -- Thiago
