On Mon, Apr 4, 2022 at 2:07 PM Ben Weidig <b...@netzgut.net> wrote: > Hi, >
Hello, Ben! > after moving to 5.8.1 on more projects, I found an issue with a missing > dependency due to some dependencies switching from 'compile' to > 'implementation' in Gradle. > I had to do that during the Gradle 4.x to 7.x upgrade and indeed I had a lot of cases I didn't know what dependency type to use. I guess I got at least this one wrong. > It's the right approach, we've done the same in our projects, but it's easy > to miss something that might be required in an edge-case. Especially if > IDEs like Eclipse can still resolve everything, but Gradle won't. > Thanks for spotting that! > In our case, tapestry-webresources no longer has the Google Closure > Compiler exposed, which is needed if a custom > org.apache.tapestry5.webresources.GoogleClosureMinimizerOptionsProvider is > provided. > > This is just a FYI mail, I've created an issue and pushed a fix already: > https://issues.apache.org/jira/browse/TAP5-2716 Awesome! Thank you! > But if you run into some missing dependencies, it might help to check > > https://github.com/apache/tapestry-5/commit/17d58c3956eee98f7684bb803d19f19b74bb22b5 > for a changed dependency. > The workaround is to include the same dependency in your own build.gradle / > pom.xml > [Insert thumbs up emoji here]. By the way, anyone else having problems with tapestry-hibernate-core classes such as org.apache.tapestry5.hibernate.HibernateSessionSource not being found after an 5.8.0 to 5.8.1 upgrade? I'm having them at my day job and I'm flabbergasted at that because they're found if you use reflection. I tried both Class.forName() and using Tapestry IoC's own ClasspathScanner. > > Cheers, > Ben > -- Thiago
