Ben Weidig: +1 (binding) Ran it against our test suite, looks good to me. If the mixins thing isn't a real issue or gets added in another snapshot, I don't see why it should postpone the release.
Cheers Ben On Thu, Mar 28, 2024 at 10:42 PM Thiago H. de Paula Figueiredo < thiag...@gmail.com> wrote: > On Thu, Mar 28, 2024 at 3:21 PM Luca Menegus <lu...@dbmsrl.com> wrote: > > > Hi Thiago, > > Hello, Luca! > > > In the commit: > > > > > https://github.com/apache/tapestry-5/commit/2b9cf7dae05c8f8dbb10aa7afda496b4969bdfd7#diff-be9ed9984523f2ebaf491922c28d644433fa64e89a093bf13cc2f2c6fbbad9fcR133 > > > > Near: > > > > private boolean isTransformed(String className) > > { > > return className != null && ( > > className.contains(".pages.") || > > className.contains(".components.") || > > className.contains(".base.")); > > > > Shouldn't the "mixins" well know package be listed as well? > > Great catch! I'll fix it later. On the other hand, that's part of some > code to try to recover from an error that should have been fixed in a > later commit included in 5.8.5, so I don't think it's a problem that > invalidates the release. > > Cheers! > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > For additional commands, e-mail: dev-h...@tapestry.apache.org > >
