[
https://issues.apache.org/jira/browse/TAVERNA-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624774#comment-14624774
]
Stian Soiland-Reyes commented on TAVERNA-846:
---------------------------------------------
Thank you for your bug report and pull request - you are right, getAnnotation()
was a legacy method. We could probably even remove it (except for the
setAnnotation for loading from older RO Bundles) - but I would wait with that
till a later version.
I would have preferred the TAVERNA-845 fix in a separate pull request, but this
time I think both could be applied, so I have merged your pull request.
> Typo and annotation missing: PathAnnotation.getAnnotion ()
> ----------------------------------------------------------
>
> Key: TAVERNA-846
> URL: https://issues.apache.org/jira/browse/TAVERNA-846
> Project: Apache Taverna
> Issue Type: Bug
> Reporter: martin scharm
> Assignee: Stian Soiland-Reyes
> Priority: Minor
>
> {{getAnnotion ()}} is probably supposed to be {{getAnnotation ()}}? Moreover,
> this method is missing the {{@JsonIgnore}} annotation and therefore
> serialises to annotations such as:
> {code:title=Bar.java|borderStyle=solid}
> {
> "uri" : "urn:uuid:2490cc20-d416-456a-8561-7c4411b51797",
> "about" : "/stuff",
> "content" : "annotations/stuff",
> "annotion" : "urn:uuid:2490cc20-d416-456a-8561-7c4411b51797"
> }
> {code}
> See
> https://github.com/apache/incubator-taverna-language/blob/d8317cc7883eba836ac2f55fd53bf07fb6325449/taverna-robundle/src/main/java/org/apache/taverna/robundle/manifest/PathAnnotation.java#L70
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
