Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/23#discussion_r36632957
--- Diff:
taverna-robundle/src/test/java/org/apache/taverna/robundle/validator/ValidatorTest.java
---
@@ -21,23 +21,45 @@
import static org.junit.Assert.*;
+import java.io.IOException;
+import java.nio.file.CopyOption;
+import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
+import java.nio.file.StandardCopyOption;
+import org.junit.Assert;
+import org.junit.Before;
import org.junit.Test;
public class ValidatorTest {
- private Path path =
Paths.get("src/test/resources/workflowrun.bundle.zip");
+ Path path;
+ @Before
+ public void copyExample() {
+ try {
+ path =
Files.createTempFile("test", ".bundle.zip");
+ } catch (IOException e1) {
+ // TODO Auto-generated catch
block
+ e1.printStackTrace();
--- End diff --
If this fails (e.g. out of disk space?), then a printStackTrace does not
help as much as simply letting the error make the whole test fail by cahnging
`copyExample` to have `throws IOEXception`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
