Thanks for a very thorough review! On 2 March 2016 at 02:49, Gale Naylor <[email protected]> wrote:
> Source file headers > - all java files checked (parent, language, and osgi) > (1) UCFPackage - several files include Oracle copyright (e.g., > OdfPackage.java). Is this OK? OK as it is Apache-licensed and includes a modification notice for changes we have done (e.g. change package name). There was no NOTICE to propagate from odfdom 0.8.6, and the copyright notice stay in the file: stain@biggie:~/Downloads$ wget http://central.maven.org/maven2/org/odftoolkit/odfdom-java/0.8.6/odfdom-java-0.8.6-sources.jar stain@biggie:~/Downloads$ unzip -t odfdom-java-0.8.6-sources.jar | grep NOTICE stain@biggie:~/Downloads$ (We could also use a later odfdom-java which is released under ASF copyright - http://www-eu.apache.org/dist/incubator/odftoolkit/sources/odftoolkit-0.6.1-incubating-src.zip-- but then some patches might have to be re-applied. This includes a NOTICE file with Portions copyright IBM, 2009-2011. All rights reserved. Portions copyright Oracle, 2008-2011. All rights reserved. ) > - xsd and other source files NOT ALL checked, but SPOT CHECK revealed: > (2) files that are listed in LICENSE, do not have Apache source file header > (e.g., xenc-schema.xsl). Is this OK? Yes, that is why they are listed in the LICENSE file. :-) > (3) jarcache.json (in robundle/resources) does not have Apache source file > header. Is this OK? Yes, JSON can't have comments. I guess we could add one with a "dc:rights" key or something though? > (4) parent release has DEPENDENCIES file that is not in GitHub. > (5) osgi release has DEPENDENCIES file that is not in GitHub. OK, it is added by the release plugin (and we added it to the rat-check ignore) > (6) osgi GitHub has several .project files. Are these part of Git? Yes, but they ideally shouldn't be in git. So they are correctly ignored in the release ZIP. (I removed them now in git for the future) -- Stian Soiland-Reyes Apache Taverna (incubating), Apache Commons RDF (incubating) http://orcid.org/0000-0001-9842-9718
