[
https://issues.apache.org/jira/browse/TAVERNA-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199147#comment-15199147
]
Stian Soiland-Reyes commented on TAVERNA-939:
---------------------------------------------
Agree that the Taverna Server should check the baclava (or data bundle) is
valid and has the correct inputs. This was trickier before when we didn't have
good libraries for dealing with Baclava.
I checked the server code, it is not validating the file is even a baclava file
- so you would not know until you run if it's broken or has the wrong inputs.
https://github.com/apache/incubator-taverna-server/blob/master/taverna-server-webapp/src/main/java/org/taverna/server/master/InputREST.java#L113
https://github.com/apache/incubator-taverna-server/blob/master/taverna-server-webapp/src/main/java/org/taverna/server/master/InputREST.java#L88
https://github.com/apache/incubator-taverna-server/blob/master/taverna-server-webapp/src/main/java/org/taverna/server/master/worker/RemoteRunDelegate.java#L356
https://github.com/apache/incubator-taverna-server/blob/master/taverna-server-worker/src/main/java/org/taverna/server/localworker/impl/LocalWorker.java#L625
I think the command line should not allow starting with a missing input.
Checking the Taverna 3 command line options I can't see how you can provide an
input databundle, only inputFiles and/or inputValues (values win over files):
https://github.com/apache/incubator-taverna-commandline/blob/master/taverna-commandline-common/src/main/java/org/apache/taverna/commandline/CommandLineTool.java#L236
https://github.com/apache/incubator-taverna-commandline/blob/master/taverna-commandline-common/src/main/java/org/apache/taverna/commandline/data/InputsHandler.java
https://github.com/apache/incubator-taverna-commandline/blob/master/taverna-commandline-api/src/main/java/org/apache/taverna/commandline/options/CommandLineOptions.java#L65
> Use taverna-baclava-language parser to vaildate workflow
> --------------------------------------------------------
>
> Key: TAVERNA-939
> URL: https://issues.apache.org/jira/browse/TAVERNA-939
> Project: Apache Taverna
> Issue Type: Bug
> Components: Taverna Commandline, Taverna Server
> Affects Versions: commandline 3.1.0, server 3.1.0
> Reporter: Ian Dunlop
> Priority: Minor
>
> An issue was reported (see http://markmail.org/message/3souha26uva4vi7z)
> where you could upload a workflow to Taverna server which had different input
> ports to the ones you specified and it would still run but never finish. This
> suggests that the workflow is not validated by the server. Since the server
> wraps the command line it would seem that the commandline module should be
> improved to use taverna-baclava-language to validate the workflow.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
