[ 
https://issues.apache.org/jira/browse/TAVERNA-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15261279#comment-15261279
 ] 

Stian Soiland-Reyes commented on TAVERNA-963:
---------------------------------------------

These "knowarc" files have not had their license headers updated, e.g.:

https://github.com/apache/incubator-taverna-common-activities/blob/master/taverna-external-tool-activity/src/main/java/de/uni_luebeck/inb/knowarc/usecases/RuntimeEnvironment.java#L1

{code}
/* Part of the KnowARC Janitor Use-case processor for taverna
 *  written 2007-2010 by Hajo Nils Krabbenhoeft and Steffen Moeller
 *  University of Luebeck, Institute for Neuro- and Bioinformatics
 *  University of Luebeck, Institute for Dermatolgy
 *
 *  This package is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU Lesser General Public License as published by
 *  the Free Software Foundation; either version 3 of the License, or
 *  (at your option) any later version.
*/
{code}

Alan/Shoaib, do I remember correctly that the University of Luebeck folks 
signed CLAs to University of Manchester - hence covered by our IP grant to ASF? 
 (In which case we are OK to replace this header and change the license to 
Apache).

> Change package name of de.uni_luebeck.inb.knowarc
> -------------------------------------------------
>
>                 Key: TAVERNA-963
>                 URL: https://issues.apache.org/jira/browse/TAVERNA-963
>             Project: Apache Taverna
>          Issue Type: Task
>          Components: Taverna Common Activities
>            Reporter: Stian Soiland-Reyes
>
> https://github.com/apache/incubator-taverna-common-activities/tree/master/taverna-external-tool-activity/src/main/java/de/uni_luebeck/inb/knowarc
> should be changed to have the package name 
> org.apache.taverna.activities.externaltool.* instead of 
> de.uni_luebeck.inb.knowarc.usecases.* and de.uni_luebeck.inb.knowarc.gui.*
> (I would avoid the "usecases" name if possible)
> Any actual UI code should probably be moved to 
> https://github.com/apache/incubator-taverna-workbench-common-activities/tree/master/taverna-external-tool-activity-ui/src/main/java/org/apache/taverna/activities/externaltool



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to